feat(sdks): replace TBD with verified registry metadata on 12 SDK rows - #3232
feat(sdks): replace TBD with verified registry metadata on 12 SDK rows#3232CodeRabbit-byte wants to merge 1 commit into
Conversation
USS-Supervisor
left a comment
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Risk: LOW
Summary: The PR is narrow to references/offers/sdks.csv and replaces TBD placeholders only in the intended metadata columns for 12 existing SDK rows. CSV parsing stays stable at 18 columns/158 rows, required validation passed, and the reviewer-owned current-cycle link-check run 32983721165 completed successfully with 13/13 successful links and 0 errors/timeouts/unknown/unsupported.
Findings: None.
Confidence: HIGH
|
Hi @eugene17kotov - this PR is stale, required CI is passing, and I don't see a blocking review. Could you please review when you have a chance? |
Rebased onto current main after upstream added new SDK rows. The conflict was line offsets only: none of the 47 cells this branch fills has been given a value upstream, verified by comparing both revisions cell by cell.
ed92942 to
573e666
Compare
|
Flagging a compliance problem with this PR that I found after it was approved, rather than letting it merge unmentioned. The
This PR modifies those columns manually. I did not know that paragraph existed when I opened this in August, and the review process did not surface it — but that does not make the edit compliant. I am not asking for an exception. #3574 now puts the question directly to the maintainers: run the automation, drop the reservation, or drop the columns. If the reservation stands, please close this PR. If it is lifted, the change is ready as it is. Every value here is sourced from the row's own action-button link — the package's registry entry or its GitHub repository — and the branch has been rebuilt on current |
2 participants
Replaces the
TBDplaceholder with verified values inlatestKnownVersion,latestKnownReleaseDate,maintainerandlicenseon 12 SDK rows referenced by the Algorand, Filecoin and Somnia listings. 47 cells, 12 rows, one file.This is the follow-up I offered in #3231, which fills the same four columns where they were empty. The rows here are disjoint from that PR — these are the ones carrying
TBD.connectkitconnectkitens-js@ensdomains/ensjsethers-jsethersfoundryfoundry-rs/foundryfvm-assemblyscript-sdkZondax/fvm-as-sdkfvm-powergate-textiletextileio/powergatehardhathardhatopenzeppelinOpenZeppelin/openzeppelin-contractsprb-testPaulRBerg/prb-testwagmiwagmiweb3-jsweb3web3-pyweb3How the package for each row was established. Only from the row itself. Four rows link their repository directly in
actionButtons(ens-js,fvm-assemblyscript-sdk,fvm-powergate-textile,prb-test). The rest link the project's own site or documentation, which resolves to exactly one canonical package:docs.ethers.orgtoethers,hardhat.orgtohardhat,wagmi.shtowagmi,web3js.readthedocs.iotoweb3,web3py.readthedocs.ioto PyPIweb3,getfoundry.shtofoundry-rs/foundry,docs.openzeppelin.com/contractstoopenzeppelin-contracts,family.co/docs/connectkittoconnectkit.24 of the 36 TBD rows are deliberately untouched. They are mostly vendor pricing tiers —
tatum-sdk-free/-pro/-scale/-starter,pinata-sdk-*,web3auth-*,dfns-sdk-*,blockdaemon-sdk-*,dynamic-sdk-*,wormhole-sdk-*,sequence-sdk-free— whose docs link points at a family of SDKs rather than one package. For those the version a row refers to cannot be established from the row, and guessing would replace an honest placeholder with a confident-looking wrong answer. If you can tell me which package each of those tiers tracks, I will happily do them in a follow-up.Two rows worth flagging rather than burying.
fvm-powergate-textilelast released in July 2021 and last saw a push in March 2023;fvm-assemblyscript-sdklast released August 2022. Neither repository is archived, so I have filled them with their genuine latest known release rather than treating them as dead — but if you consider a provider at that age defunct, those two rows may deserve a separate look. That is a listing decision rather than a metadata one, so I have not acted on it.Safety of the edit. A scripted diff against
upstream/mainconfirms 12 lines changed, no column width changes, no edits outside the four target columns, and no cell overwritten that held anything other than the exact stringTBD. Formatting follows the rows that already carry real values: bare semver with novprefix, ISOYYYY-MM-DDdates, SPDX licence identifiers.validate_csv.pyfrom thejson-toolsbranch:All checks passed.No links added or changed.Reward address:
0x1589423BeCC3F87EA9406155EaF4D5E04C34Dcf1(USDC/USDT, Ethereum mainnet)