data(providers): fill 40 missing link cells for 28 providers (batch 1 of 4) - #3323
data(providers): fill 40 missing link cells for 28 providers (batch 1 of 4)#3323EazyHood wants to merge 1 commit into
Conversation
Summary
Errors per inputErrors in ./references/providers/providers.csv
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: REQUEST_CHANGES
Risk: MEDIUM
Summary: The provider CSV remains structurally valid, but one newly filled provider social field is unsupported by the provider's own site.
Findings: MEDIUM - references/providers/providers.csv, row core-dao, field x: the PR sets the X handle to name, which appears to be leaked metadata rather than Core DAO's official X account. Core DAO's own website links to twitter.com/Coredao_Org. Please replace this with Coredao_Org or leave the field blank if you cannot confirm the official handle.
Confidence: HIGH
Required validation passed. Current-cycle link-check run 33375666339 completed with workflow success but its report still showed 1 URL error, so this review cannot approve the PR in this cycle.
bda8354 to
11dc7bd
Compare
|
One thing worth flagging before the link-check runs on this, because it is likely to report X throttles GitHub-hosted runners. In the most recent link-check run on #2977 — 2663 links checked — 25 of the 42 errors were on Those accounts are live; all three return 200 from an ordinary connection. The same handle comes back as I have already removed every For the Everything else in these rows was re-checked against your accept list ( |
11dc7bd to
731de16
Compare
731de16 to
ea5c495
Compare
|
On the While fixing that I rebased all four batches on current |
Summary
Fills 40 empty cells across 28 providers in
references/providers/providers.csv(1rpc…forge). No rows added or removed, and no cell that already had a value was changed.githubdocsxdiscordtelegramOne of four batches (#3323, #3324, #3325, #3326) covering different providers; no cell appears in more than one of them. Rebased on current
main— the earlier version conflicted after #3211, #3218, #2814 and #3309 touched this file, which is also why no workflow ran on it (GitHub does not triggerpull_requestworkflows on a conflicting PR).Type of change
Scope
Networks affected: global (provider identities, not listings)
Categories affected:
references/providersAdditional notes, additional context / screenshots:
Overlap with #3250, stated up front. #3250 fills 450 provider cells and 15 of the cells in this PR are also in it — with the same value in every case; where the two disagreed, the cell was removed from here. Whichever lands second rebases and those cells become a no-op in it, so nothing is claimed twice. They are kept here because #3250 is large and has been cycling on link-check noise since 27 August, and these batches are small enough to clear a review cycle on their own.
Where the values come from. Two first-party sources, never a guess from the slug: the provider's own website (outbound links and
twitter:sitemeta tag), and the provider's own GitHub organisation profile (twitter_username), plus the provider's owndocs./developers.subdomain accepted only when the URL after redirects stays on the provider's registrable domain. A value was written only when unambiguous; where two plausible candidates existed, the cell was left empty. That is why these four PRs fill ~160 cells and not the ~650 that are empty.Accuracy, measured before writing anything, by running the same extraction against providers whose value is already recorded:
A third source was measured and rejected: the GitHub profile's
blogfield agrees with the recordedwebsiteonly 80.7% of the time, so nowebsitecell is touched.Link checking. Every link in every touched row — the cells added here and the
website/docsvalues already present in those rows — was requested with TLS verification on and compared against the accept list this repo's link-check uses (200,202,204,400,401,403,405,429): across the four batches, 523 links, 0 failures. Three rows that could have been filled were left out because they carry a link that was already in the database and fails today (swing: expired certificate and a docs domain that no longer resolves;polyzoa: 404;learnweb3: 503) — since the check reads whole rows, touching them reports those failures against this PR. Nolinkedincell is included, for the reason in #3347.Changed since the first review on this PR:
core-dao'sxwasname— Core DAO's own page carries<meta name="twitter:site" content="@name">, an unfilled template value that my extractor took at face value. It is nowCoredao_Org, which is what the same page links to and which returns 200.Style Guide conformance.
docsas a full quoted URL;x,github,discord,telegramas value-after-domain only;discordas the bare invite code, matching 125 of the 136 existing values. Row order untouched, so the file stays A–Z byslug.Links
linkedinis excluded.Validation checklist
!providersyntax, and that entities in/networkssub-folders inherits records from/providersfolderOptional