data(providers): fill 50 missing link cells for 28 providers (batch 4 of 4) - #3326
data(providers): fill 50 missing link cells for 28 providers (batch 4 of 4)#3326EazyHood wants to merge 1 commit into
Conversation
Summary
Errors per inputErrors in ./references/providers/providers.csv
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: REQUEST_CHANGES
Risk: MEDIUM
Summary: The provider CSV remains structurally valid, but the current-cycle link-check found hard failures in touched provider rows, so the PR is not approval-ready.
Findings: MEDIUM - references/providers/providers.csv, rows swing and polyzoa: the link-check report flags https://swing.xyz with an SSL certificate error, https://developers.swing.xyz/ with a connection/DNS failure, and https://www.polyzoa.xyz/ as 404 Not Found; direct checks confirmed Swing's certificate failure, the Swing developer-docs DNS failure, and Polyzoa's site availability problem. Please update these provider URLs to working official endpoints, or leave the affected fields blank if no working official URL is available.
Confidence: HIGH
Required validation passed. Current-cycle link-check run 33375659246 reported 161 successful links, 3 errors, 0 timeouts, and 0 unsupported URLs.
3c06320 to
aa75ca6
Compare
|
Thanks — this was useful, and it found more than the three links. On the three flagged links: they were already in the database. None of them is a value this PR added. The rows are: This PR added I did not substitute replacement URLs, because the obvious candidates are wrong:
A third row, Two further problems I found while checking, and fixed here: 1. Every 2. Twenty cells appeared in two of my own PRs, seven of them with different values ( What changed across the four PRs
Every link in every touched row — the added values and the Ready for another look. |
|
One thing worth flagging before the link-check runs on this, because it is likely to report X throttles GitHub-hosted runners. In the most recent link-check run on #2977 — 2663 links checked — 25 of the 42 errors were on Those accounts are live; all three return 200 from an ordinary connection. The same handle comes back as I have already removed every For the Everything else in these rows was re-checked against your accept list ( |
aa75ca6 to
d77d9af
Compare
d77d9af to
76305cf
Compare
Summary
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: COMMENT
Risk: LOW
Summary: The provider-link batch is scoped to filling empty provider metadata cells, and the refreshed diff keeps provider CSV formatting intact.
Findings: None from static review. CSV width is stable, provider social/link fields use the expected repository formats, and no unrelated files are touched. I am not approving this cycle because I could not verify a current-cycle link-check success before cleanup.
Confidence: MEDIUM
|
For the next review cycle: the current-cycle link-check on this head is run 33737231694, posted above at the same minute as the review — 111 links checked, 0 errors, 0 timeouts. https://github.com/Chain-Love/chain-love/actions/runs/33737231694 |
Summary
Fills 50 empty cells across 28 providers in
references/providers/providers.csv(stylus-sdk…ziion-linux-distro). No rows added or removed, and no cell that already had a value was changed.githubdocsxdiscordtelegramOne of four batches (#3323, #3324, #3325, #3326) covering different providers; no cell appears in more than one of them. Rebased on current
main— the earlier version conflicted after #3211, #3218, #2814 and #3309 touched this file, which is also why no workflow ran on it (GitHub does not triggerpull_requestworkflows on a conflicting PR).Type of change
Scope
Networks affected: global (provider identities, not listings)
Categories affected:
references/providersAdditional notes, additional context / screenshots:
Overlap with #3250, stated up front. #3250 fills 450 provider cells and 37 of the cells in this PR are also in it — with the same value in every case; where the two disagreed, the cell was removed from here. Whichever lands second rebases and those cells become a no-op in it, so nothing is claimed twice. They are kept here because #3250 is large and has been cycling on link-check noise since 27 August, and these batches are small enough to clear a review cycle on their own.
Where the values come from. Two first-party sources, never a guess from the slug: the provider's own website (outbound links and
twitter:sitemeta tag), and the provider's own GitHub organisation profile (twitter_username), plus the provider's owndocs./developers.subdomain accepted only when the URL after redirects stays on the provider's registrable domain. A value was written only when unambiguous; where two plausible candidates existed, the cell was left empty. That is why these four PRs fill ~160 cells and not the ~650 that are empty.Accuracy, measured before writing anything, by running the same extraction against providers whose value is already recorded:
A third source was measured and rejected: the GitHub profile's
blogfield agrees with the recordedwebsiteonly 80.7% of the time, so nowebsitecell is touched.Link checking. Every link in every touched row — the cells added here and the
website/docsvalues already present in those rows — was requested with TLS verification on and compared against the accept list this repo's link-check uses (200,202,204,400,401,403,405,429): across the four batches, 523 links, 0 failures. Three rows that could have been filled were left out because they carry a link that was already in the database and fails today (swing: expired certificate and a docs domain that no longer resolves;polyzoa: 404;learnweb3: 503) — since the check reads whole rows, touching them reports those failures against this PR. Nolinkedincell is included, for the reason in #3347.Style Guide conformance.
docsas a full quoted URL;x,github,discord,telegramas value-after-domain only;discordas the bare invite code, matching 125 of the 136 existing values. Row order untouched, so the file stays A–Z byslug.Links
linkedinis excluded.Validation checklist
!providersyntax, and that entities in/networkssub-folders inherits records from/providersfolderOptional