products: skip tripwire when every appearance is unresponsive - #1262
Merged
Conversation
…onsive The tripwire on the /products/[slug] route throws when a provider has 3+ appearances all with rank=0, assuming the pattern means the store read failed mid-render. For Cloudflare's public Ethereum gateway (recently switched to permissioned mode, returns -32046 on most JSON-RPC methods), the pattern is real: every bench that ranks it lands rank=0 because every probe fails. That single 500 has been tripping the sitemap smoke test on every prod deploy for 24h, auto-rolling back every merge to main including the SEO pack and the ticker sanity clamp. Skip the tripwire when every appearance is explicitly marked unresponsive or availability=unavailable. Real store failures leave those flags unset, so this preserves the guard's original intent without blocking prod on a genuinely dead provider.
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the /products/cloudflare 500 that has been auto-rollbacking every prod deploy for 24 hours (SEO pack #1256, ticker sanity clamp #1258/#1259, cherry-pick #1248 and multiple bench specs all reverted). See commit body for detail.