sweep/2026-09-22: 3-cycle maintenance sweep

[Chartres]

Sweep summary

Product: mac-dir-stat Branch: sweep/2026-09-22 Cycles: 3 Commits: 34 Tests: 7 → 35

3-cycle Red→Green→Refactor sweep. All 34 commits were built with cargo test passing after each one.

Findings table

Finding	Severity	Status
UTF-8 byte-slice panic on non-ASCII dir names (dir_tree.rs:190, treemap_view.rs:438)	critical	fixed
app_open / scan_completed off-taxonomy → KPI buckets permanently zero	critical	fixed
collect_files().len() every frame (full recursive walk + Vec alloc per frame)	critical	fixed
is_alive() panics on out-of-range NodeId (stale-id guard was itself unsafe)	critical	fixed
start_scan didn't clear partial_refresh_receiver → stale graft panic after rescan	critical	fixed
Keyboard handlers (⌘⌫, Enter, ⇧⌘R) used node data without liveness check	critical	fixed
telemetry.txt absent → default opted-in; page_view fires before first UI frame	major	fixed
set_telemetry_opt_out discarded write error silently	major	fixed
feedback_sent = true even when telemetry off (no send happened)	major	fixed
feedback_text cleared unconditionally, wiping unsent text	major	fixed
cleanup.rs:91 path-suffix match not component-bounded (MyLibrary/Caches matched Library/Caches)	major	fixed
target bare-name rule matched any directory, including ~/Documents/target	major	fixed
.Trash/.Trashes offered as cleanup candidates (nonsensical + root-owned)	major	fixed
Library/Containers/com.apple.iCloud.iCloudDrive described as safe to evict (data loss)	major	fixed
.m2/.gradle rules gave no warning about credential files (settings.xml, gradle.properties)	major	fixed
move_to_trash failure eprintln-only, no UI feedback	major	fixed
empty_trash blocked UI thread with synchronous .status()	major	fixed
empty_trash failure not surfaced in status_message	major	fixed
Cleanup window category headers repeated (sorted by size, not by category)	major	fixed
start_scan left pending_action, hovered_dir, cleanup_candidates stale	major	fixed
poll_scan Done didn't clear pending_action, hovered_dir, scroll_dir_tree_to	major	fixed
recompute_sizes_upward wrote into dead nodes	major	fixed
PendingAction::RevealInFinder / MoveToTrash never constructed (dead variants)	major	fixed
children_sorted, node_count, StrRef::EMPTY dead code	minor	fixed
BAR_FILL unused color constant; ext_list redundant branch; unused ColorMode import	minor	fixed
Path truncation in cleanup window was lengthening short paths	minor	fixed

Tests added

• test_classify_cargo_target — Cargo.toml-sibling check
• test_classify_non_cargo_target — no Cargo.toml → not classified
• test_classify_library_caches — Library/Caches path
• test_classify_gradle_warning — .gradle warning in description
• test_no_telemetry_env_var_opts_out — MACDIRSTAT_NO_TELEMETRY=1 path

Refactors

• One confirm_dialog widget replacing three copy-pasted modal dialogs
• HashSet::retain replacing manual loop; Option::is_some_and for map_or(false, …) predicates
• Dead PendingAction variants removed, making the dispatch match exhaustive
• Single iterative mark_descendants_dead replacing two divergent recursive/iterative walks
• to_screen() helper eliminating 6 copies of the same rect-conversion in treemap_view
• Color-mode shortcuts table-driven; ScanProgressInfo derives Default

Not fixed (scope/risk)

• src/scanner/tree.rs:127 — node()/node_mut() still index without bounds check (changing return type to Option would require touching ~40 call sites; is_alive is now safe so callers can guard before calling)
• src/flywheel.rs:109 — /dev/urandom fallback entropy (uuid quality only matters for analytics dedup; low impact)
• src/scanner/tree.rs:33 — u32 arena offset overflow (4 GiB of interned strings is not a realistic concern)
• Various per-frame allocation patterns in dir_tree.rs (require dirty-tracking/caching refactor)

🤖 Generated with Claude Code