sweep/2026-09-22: 3-cycle maintenance sweep - #2

Open

Chartres wants to merge 35 commits into

mainfrom

sweep/2026-09-22

Commits on Sep 21, 2026

fix: char-safe truncation in dir_tree to avoid UTF-8 byte-slice panic

Chartres
and
claude
committed
3fd0b9c
fix: char-safe truncation in treemap_view to avoid UTF-8 byte-slice panic

Chartres
and
claude
committed
2611a65
fix: use taxonomy event name 'page_view' instead of 'app_open'

Chartres
and
claude
committed
089192e
fix: use taxonomy event name 'key_action' instead of 'scan_completed'

Chartres
and
claude
committed
1bcea23
fix: use node.file_count instead of collect_files().len() in status bar

Chartres
and
claude
committed
d21b056
fix: require path-component boundary in cleanup suffix matching

Chartres
and
claude
committed
9f03ead
fix: surface move_to_trash failure as status bar error message

Chartres
and
claude
committed
cb8f3ab
fix: only set feedback_sent when telemetry is enabled

Chartres
and
claude
committed
5ba9f8e
fix: path truncation in cleanup window (20+ellipsis+20 chars)

Chartres
and
claude
committed
28f0fca
fix: remove dead code children_sorted, node_count, StrRef::EMPTY

Chartres
and
claude
committed
81337c0
fix: remove unused BAR_FILL, simplify ext_list branch, drop unused ColorMode import

Chartres
and
claude
committed
97f9558
refactor: drop never-constructed PendingAction variants

Chartres
and
claude
committed
07a299a
refactor: use stdlib where code was hand-rolling it

Chartres
and
claude
committed
54dfbc0
refactor: one confirm_dialog widget for all three confirmations

Chartres
and
claude
committed
7d885ae
fix: clear pending_action/hovered_dir/cleanup/scroll_dir_tree_to in start_scan

Chartres
and
claude
committed
9b5444c
fix: clear pending_action/hovered_dir/scroll/selected_extension in scan Done branch

Chartres
and
claude
committed
53c669e
fix: remove .Trash/.Trashes from cleanup candidates (nonsensical + root-owned)

Chartres
and
claude
committed
ea06fa9
fix: remove iCloud Drive evictable cache rule (data loss risk for non-uploaded files)

Chartres
and
claude
committed
3862bb4
fix: warn about credential files in .gradle and .m2 cleanup descriptions

Chartres
and
claude
committed
f6fab58
fix: only classify 'target' as Cargo output when Cargo.toml exists in parent

Chartres
and
claude
committed
0320158
fix: surface write error in set_telemetry_opt_out via eprintln

Chartres
and
claude
committed
921802c
fix: default telemetry to opted-out when telemetry.txt is absent

Chartres
and
claude
committed
c0c255a
fix: sort cleanup candidates by category then size for contiguous grouping

Chartres
and
claude
committed
84f57b4
fix: empty_trash uses spawn() to avoid blocking UI thread; surface error in status_message

Chartres
and
claude
committed
77e1b69
test: add classify tests for cargo target, non-cargo target, Library/Caches, .gradle

Chartres
and
claude
committed
1ec21b6
test: add no_telemetry_env_var_opts_out test for MACDIRSTAT_NO_TELEMETRY=1

Chartres
and
claude
committed
777fe90
fix: only clear feedback_text when telemetry is enabled and send actually happened

Chartres
and
claude
committed
86bd207
refactor: single iterative descendant-dead walk in FileTree

Chartres
and
claude
committed
fd984ab
refactor: one to_screen() for treemap rect conversion

Chartres
and
claude
committed
ef9ec8e
refactor: table-drive color-mode shortcuts, derive Default for ScanProgressInfo

Chartres
and
claude
committed
253395e
fix: is_alive returns false for out-of-range NodeId

Chartres
and
claude
committed
bdb9836
fix: start_scan clears partial_refresh_receiver and status_message

Chartres
and
claude
committed
e5376fa

Commits on Sep 22, 2026

fix: guard keyboard handlers with is_alive before accessing node data

Chartres
and
claude
committed
b7cb2cc
fix: recompute_sizes_upward skips dead nodes

Chartres
and
claude
committed
908e631
refactor: add dir_of(id) helper to eliminate repeated is_alive/is_dir/parent checks

Chartres
and
claude
committed
ec83408

Navigation Menu

sweep/2026-09-22: 3-cycle maintenance sweep - #2

sweep/2026-09-22: 3-cycle maintenance sweep#2
Chartres wants to merge 35 commits into
mainfrom
sweep/2026-09-22

Commits on Sep 21, 2026

fix: char-safe truncation in dir_tree to avoid UTF-8 byte-slice panic

fix: char-safe truncation in treemap_view to avoid UTF-8 byte-slice panic

fix: use taxonomy event name 'page_view' instead of 'app_open'

fix: use taxonomy event name 'key_action' instead of 'scan_completed'

fix: use node.file_count instead of collect_files().len() in status bar

fix: require path-component boundary in cleanup suffix matching

fix: surface move_to_trash failure as status bar error message

fix: only set feedback_sent when telemetry is enabled

fix: path truncation in cleanup window (20+ellipsis+20 chars)

fix: remove dead code children_sorted, node_count, StrRef::EMPTY

fix: remove unused BAR_FILL, simplify ext_list branch, drop unused ColorMode import

refactor: drop never-constructed PendingAction variants

refactor: use stdlib where code was hand-rolling it

refactor: one confirm_dialog widget for all three confirmations

fix: clear pending_action/hovered_dir/cleanup/scroll_dir_tree_to in start_scan

fix: clear pending_action/hovered_dir/scroll/selected_extension in scan Done branch

fix: remove .Trash/.Trashes from cleanup candidates (nonsensical + root-owned)

fix: remove iCloud Drive evictable cache rule (data loss risk for non-uploaded files)

fix: warn about credential files in .gradle and .m2 cleanup descriptions

fix: only classify 'target' as Cargo output when Cargo.toml exists in parent

fix: surface write error in set_telemetry_opt_out via eprintln

fix: default telemetry to opted-out when telemetry.txt is absent

fix: sort cleanup candidates by category then size for contiguous grouping

fix: empty_trash uses spawn() to avoid blocking UI thread; surface error in status_message

test: add classify tests for cargo target, non-cargo target, Library/Caches, .gradle

test: add no_telemetry_env_var_opts_out test for MACDIRSTAT_NO_TELEMETRY=1

fix: only clear feedback_text when telemetry is enabled and send actually happened

refactor: single iterative descendant-dead walk in FileTree

refactor: one to_screen() for treemap rect conversion

refactor: table-drive color-mode shortcuts, derive Default for ScanProgressInfo

fix: is_alive returns false for out-of-range NodeId

fix: start_scan clears partial_refresh_receiver and status_message

Commits on Sep 22, 2026

fix: guard keyboard handlers with is_alive before accessing node data

fix: recompute_sizes_upward skips dead nodes

refactor: add dir_of(id) helper to eliminate repeated is_alive/is_dir/parent checks