Repository navigation
feat(ui): finish the Caramel launcher — splash, modals and live instance actions - #186
Merged
Merged
Conversation
…tance actions The first port mounted the frame and the six tabs, but left the app with no cold-start screen and no way to reach the things the tabs point at: the splash was a stub that drew nothing and started nothing, and the account, screenshots, instance-settings and friends actions had no host behind them. Splash ------ SplashActivity is the only LAUNCHER entry, so while it was a stub the app never left it. It now warms VersionManager asynchronously and hands over to MainActivity, with a 4s backstop so a stalled store still reaches the launcher (where the readiness state is shown) instead of stranding the user. The screen is Compose (CaramelSplashScreen) on the pack's backdrop, and the window background is the same navy, so the first frame does not flash white. Modals ------ CaramelModals/CaramelModalParts add the pack's account menu, account settings, add-account (Microsoft device-code flow), screenshots grid, friends list, add friend and instance settings, and the launcher-settings panel. Every one is wired to a real action on MainActivity rather than a demo row: the screenshots grid reads the instance's real folder, the friends list the active account's real Xbox Live friends, and the instance settings drive VersionManager. Instance actions ---------------- MainActivity implements the new Actions (startSignIn, signOut, renameInstance, repairInstance, deleteInstance, openInstanceFolder, addServer, toggleServerFavourite, openScreenshots, openScreenshot, deleteScreenshot). Sign-in runs on the shared network pool rather than a bare thread. LocalFileOpener is the one audited place an ACTION_VIEW with a content: uri is built, so the folder and screenshot opens are safe and lint-clean; the file: uri the port used is not readable by another app since API 24 and would have opened a chooser that then failed. CaramelScreenshotInfo, the server port/favourite fields and the cosmetic kind enum carry the data the new screens draw. Co-authored-by: openhands <openhands@all-hands.dev>
Lynxifyy
marked this pull request as ready for review
November 15, 2026 00:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Completes the Caramel UI pack port that PR #185 started. The first port mounted the frame and the six tabs; this one gives the app a cold-start screen and puts a real host behind the account, screenshots, friends and instance-settings surfaces that the tabs point at.
Splash
SplashActivityis the onlyLAUNCHERentry, so while it was a stub the app never left it. It now warmsVersionManagerasynchronously and hands over toMainActivity, with a 4s backstop so a stalled store still reaches the launcher (where the readiness state is shown) instead of stranding the user. The screen is Compose (CaramelSplashScreen) on the pack's backdrop, and the window background is the same navy, so the first frame does not flash white.Modals
CaramelModals/CaramelModalPartsadd the pack's account menu, account settings, add-account (Microsoft device-code flow), screenshots grid, friends list, add friend, instance settings and the launcher-settings panel. Every one is wired to a real action rather than a demo row: the screenshots grid reads the instance's real folder, the friends list the active account's real Xbox Live friends, and the instance settings driveVersionManager.Instance actions
MainActivityimplements the newActions(startSignIn,signOut,renameInstance,repairInstance,deleteInstance,openInstanceFolder,addServer,toggleServerFavourite,openScreenshots,openScreenshot,deleteScreenshot). Sign-in runs on the shared network pool rather than a bare thread.LocalFileOpeneris the one audited place anACTION_VIEWwith acontent:uri is built, so the folder and screenshot opens are safe and lint-clean. Thefile:uri the port used is not readable by another app since API 24 and would have opened a chooser that then failed.CaramelScreenshotInfo, the serverport/favouritefields and the cosmetic-kind enum carry the data the new screens draw.Verification
:app:testDebugUnitTest— 3167 tests, 0 failures:app:assembleDebug(incl. NDK) — green:app:lintDebug— greenscripts/check_ui_hygiene.py,scripts/verify_berryapi_abi.py,scripts/check_submodules.sh,scripts/validate_release_content.py— cleanDevice-only behaviour (real FPS, launch timing, hook behaviour against a real
libminecraftpe.so) cannot be measured here; no emulator is available in this environment.