Fix undefined array key warning when iframe parameters are omitted and add Chinese language support - #21
Open
doge24190 wants to merge 2 commits into
Open
Fix undefined array key warning when iframe parameters are omitted and add Chinese language support#21doge24190 wants to merge 2 commits into
doge24190 wants to merge 2 commits into
Conversation
Use array_pad to ensure $param is always set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Fixes #20.
When using iframe syntax without optional parameters, for example:
{{url>https://example.com}}explode(' ', $url, 2) returns only one element. Assigning it to
list($url, $param) triggers an "Undefined array key 1" warning on PHP 8.x.
This change pads the exploded array with an empty string so $param defaults
to the expected "no parameters" value.
2. Add Chinese language support