Skip to content

Fix undefined array key warning when iframe parameters are omitted and add Chinese language support #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doge24190 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix undefined array key warning when iframe parameters are omitted and add Chinese language support #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
437606a
Ensure $param is initialized in handle function
doge24190 May 21, 2026
d0377c9
add Chinese language support
doge24190 May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lang/zh/settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php
/**
* Chinese language file
*
* @license GPL 2 (http://www.gnu.org/licenses/gpl.html)
* @author doge24190 <me@doge24190.top>
*/

// for the configuration manager
$lang['js_ok'] = '允许含有javascript的url链接';
2 changes: 1 addition & 1 deletion plugin.info.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
base iframe
author Christopher Smith
email chris@jalakai.co.uk
date 2023-08-17
date 2026-05-22
name iframe plugin
desc Allows external URLs to be loaded into an iframe in your DokuWiki page.
url http://www.dokuwiki.org/plugin:iframe
2 changes: 1 addition & 1 deletion syntax.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function connectTo($mode) { $this->Lexer->addSpecialPattern('{{url>.*?}}',$mode,
function handle($match, $state, $pos, Doku_Handler $handler){
$match = substr($match, 6, -2);
list($url, $alt) = array_pad(explode('|',$match,2), 2, null);
list($url, $param) = explode(' ',$url,2);
list($url, $param) = array_pad(explode(' ',$url,2), 2, '');

// javascript pseudo uris allowed?
if (!$this->getConf('js_ok') && substr($url,0,11) == 'javascript:'){
Expand Down