Modernize examples#100
Conversation
| using Oceananigans | ||
| using Oceananigans.Units | ||
| using Oceananigans.Utils: Time | ||
| using Oceananigans.OutputReaders |
There was a problem hiding this comment.
we shouldn't have to import this
something I put in the AGENTS.md file for Oceananigans was to minimize import statements in examples. Examples should exercise the public user interface, which is exported by using ClimaSeaIce.
We could also reexport the relevant parts of the Oceananigans interface by ClimaSeaIce directly. This is the approach I am taking with Breeze, so that people only need to write using Breeze.
| Q_shortwave = FluxFunction(linearly_interpolate_solar_flux, parameters=Rs) | ||
| Q_longwave = FluxFunction(linearly_interpolate_flux, parameters=Rl) | ||
| Q_sensible = FluxFunction(linearly_interpolate_flux, parameters=Qs) | ||
| Q_latent = FluxFunction(linearly_interpolate_flux, parameters=Ql) | ||
| Q_emission = RadiativeEmission(emissivity=ϵ, stefan_boltzmann_constant=σ) |
There was a problem hiding this comment.
suggest coming up with mathematical notation for these (we will eventually codify this in Horizon/ClimaOcean)
|
are the examples all loaded in the docs? could be another change to make |
|
Maybe add an AGENTS.md file in this PR as well for ClimaSeaIce? |
|
#115 is also relevant here; but can definitely be left for a new PR! |
|
Let's merge this and I'll work on #115 on a different PR |
3 participants
I thought the examples might be a bit of modernization. I asked cursor to change the descriptions to match the style of Oceananigans. I am not sure about the result