ci: disable automatic workflow triggers, add workflow_dispatch#72
ci: disable automatic workflow triggers, add workflow_dispatch#72devin-ai-integration[bot] wants to merge 1 commit into
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔴 delete-blacksmith-cache.yml: delete-cache-build-on-pr-close job is unreachable — PR caches are never cleaned
The pull_request: types: [closed] trigger was removed (lines 9-10 on the left), but the delete-cache-build-on-pr-close job at line 22 still checks if: github.event_name == 'pull_request' && github.event.action == 'closed'. Since workflow_dispatch is now the only trigger, this condition can never be true, and the job is dead code. Build caches (prod-build-*) for closed PRs will never be cleaned up, leading to cache accumulation.
(Refers to line 22)
Prompt for agents
The delete-blacksmith-cache.yml workflow lost its pull_request: types: [closed] trigger, but the delete-cache-build-on-pr-close job (line 22) still checks for github.event_name == 'pull_request'. This condition can never be true with only workflow_dispatch as a trigger.
This means build caches for closed PRs will never be cleaned up, leading to cache accumulation over time.
The pull_request: types: [closed] trigger should be restored alongside workflow_dispatch to preserve the automatic cleanup behavior.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
By design — this PR deliberately disables all automatic triggers to reduce Actions spend. The dead pull_request condition is expected since the workflow is no longer auto-triggered on PR close events.
| @@ -1,7 +1,6 @@ | |||
| on: | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
🔴 cleanup-report.yml: workflow_dispatch trigger causes rm -rf reports/ to delete ALL reports
When triggered via workflow_dispatch, github.event.pull_request.head.ref evaluates to an empty string. This makes BRANCH_REPORTS_DIR resolve to reports/ (no branch suffix) and HEAD_REF to an empty string. If the reports/ directory exists in the checked-out repo, the rm -rf "$BRANCH_REPORTS_DIR" command at line 39 will delete ALL test reports for ALL branches, not just a specific branch's reports. Previously, the pull_request: types: [closed] trigger ensured PR context was always available.
Prompt for agents
The cleanup-report.yml workflow was changed from a pull_request closed trigger to workflow_dispatch, but the job body still depends on github.event.pull_request.head.ref (lines 35-36). When triggered via workflow_dispatch, this context is empty, causing BRANCH_REPORTS_DIR to be just 'reports/' — which means rm -rf will delete ALL reports for every branch.
Options:
1. Restore the pull_request: types: [closed] trigger (keep workflow_dispatch and workflow_call as additional triggers)
2. If workflow_dispatch is needed, add a required input parameter for the branch name and use that when the PR context is missing
3. Add a guard that checks if HEAD_REF is non-empty before proceeding with deletion
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
By design — this PR deliberately disables all automatic triggers to reduce Actions spend. The rm -rf command would only execute if manually triggered via workflow_dispatch, and the empty HEAD_REF means it would target reports/ which would be a no-op if the directory doesn't exist in the checkout. The workflow is effectively disabled from doing anything automatically.
| pull_request: | ||
| types: | ||
| - closed | ||
| workflow_dispatch: |
There was a problem hiding this comment.
🔴 cache-clean.yml: github.event.pull_request.number is empty on workflow_dispatch, producing malformed branch ref
The BRANCH variable is set to refs/pull/${{ github.event.pull_request.number }}/merge (line 17). With the trigger changed from pull_request: types: [closed] to workflow_dispatch, github.event.pull_request.number is undefined/empty, producing the malformed branch reference refs/pull//merge. The subsequent gh actions-cache list and gh actions-cache delete commands will find no caches matching this invalid reference, making the entire cleanup workflow a silent no-op.
Prompt for agents
The cache-clean.yml workflow was changed from a pull_request closed trigger to workflow_dispatch, but the script still references github.event.pull_request.number on line 17 to construct the BRANCH variable. On workflow_dispatch events, this context is absent, making the branch ref 'refs/pull//merge' which is invalid.
Options:
1. Restore the pull_request: types: [closed] trigger alongside workflow_dispatch
2. Add a workflow_dispatch input for the PR number and use it to construct the branch reference
3. If the intent is to only trigger manually, add the PR number as a required input
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
By design — this PR deliberately disables all automatic triggers to reduce Actions spend. The dead PR context references are expected since the workflow is no longer auto-triggered on PR events.
| on: | ||
| pull_request_target: | ||
| types: [labeled] | ||
| workflow_dispatch: |
There was a problem hiding this comment.
🔴 run-ci.yml: Job condition always false on workflow_dispatch — workflow is completely broken
The trigger was changed from pull_request_target: types: [labeled] to workflow_dispatch, but the trigger job's if condition on line 13 checks github.event.label.name == 'run-ci' || github.event.label.name == 'ready-for-e2e'. On a workflow_dispatch event, github.event.label does not exist, so this condition always evaluates to false. The job will never run, breaking the CI re-trigger mechanism for external contributors who need the run-ci label flow.
Prompt for agents
The run-ci.yml workflow was changed from pull_request_target: types: [labeled] to workflow_dispatch, but the job condition on line 13 still expects github.event.label.name from a label event. This field is never present in a workflow_dispatch event, so the trigger job can never execute.
This workflow is the mechanism for maintainers to approve CI runs for external contributors by adding the run-ci or ready-for-e2e label. With this change, that flow is completely broken.
The pull_request_target: types: [labeled] trigger needs to be restored for this workflow to function.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
By design — this PR deliberately disables all automatic triggers to reduce Actions spend. The run-ci label flow is intentionally disabled. The workflow can be re-enabled by restoring the pull_request_target trigger if needed in the future.
1 participant
Summary
Disable automatic GitHub Actions triggers (11 cron schedules, 12
pull_request/pushworkflows) to reduce Actions spend. All job definitions are preserved — workflows can be triggered manually viaworkflow_dispatch.Files modified:
cache-clean.yml,changesets.yml,cleanup-report.yml,cron-bookingReminder.yml,cron-changeTimeZone.yml,cron-checkSmsPrices.yml,cron-downgradeUsers.yml,cron-monthlyDigestEmail.yml,cron-scheduleEmailReminders.yml,cron-scheduleSMSReminders.yml,cron-scheduleWhatsappReminders.yml,cron-stale-issue.yml,cron-syncAppMeta.yml,cron-webhooks-triggers.yml,delete-blacksmith-cache.yml,i18n.yml,labeler.yml,nextjs-bundle-analysis.yml,post-release.yml,pr.yml,release-docker.yaml,run-ci.yml,semantic-pull-requests.ymlReview & Testing Checklist for Human
workflow_dispatchfor manual triggeringNotes
This is part of an org-wide effort to reduce GitHub Actions spend by disabling automatic triggers across all repos.
Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/7b4b537d6a95428d85ae1cf444f374ce
Requested by: @bsmitches