Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/cache-clean.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
name: cleanup caches by a branch
on:
pull_request:
types:
- closed
workflow_dispatch:
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 cache-clean.yml: github.event.pull_request.number is empty on workflow_dispatch, producing malformed branch ref

The BRANCH variable is set to refs/pull/${{ github.event.pull_request.number }}/merge (line 17). With the trigger changed from pull_request: types: [closed] to workflow_dispatch, github.event.pull_request.number is undefined/empty, producing the malformed branch reference refs/pull//merge. The subsequent gh actions-cache list and gh actions-cache delete commands will find no caches matching this invalid reference, making the entire cleanup workflow a silent no-op.

Prompt for agents
The cache-clean.yml workflow was changed from a pull_request closed trigger to workflow_dispatch, but the script still references github.event.pull_request.number on line 17 to construct the BRANCH variable. On workflow_dispatch events, this context is absent, making the branch ref 'refs/pull//merge' which is invalid.

Options:
1. Restore the pull_request: types: [closed] trigger alongside workflow_dispatch
2. Add a workflow_dispatch input for the PR number and use it to construct the branch reference
3. If the intent is to only trigger manually, add the PR number as a required input
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By design — this PR deliberately disables all automatic triggers to reduce Actions spend. The dead PR context references are expected since the workflow is no longer auto-triggered on PR events.


jobs:
cleanup:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/changesets.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
name: Create PR containing updated CHANGELOG.md and release packages to NPM once PR is merged

on:
push:
branches:
- main
workflow_dispatch:

concurrency: ${{ github.workflow }}-${{ github.ref }}
permissions:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/cleanup-report.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
on:
workflow_dispatch:
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 cleanup-report.yml: workflow_dispatch trigger causes rm -rf reports/ to delete ALL reports

When triggered via workflow_dispatch, github.event.pull_request.head.ref evaluates to an empty string. This makes BRANCH_REPORTS_DIR resolve to reports/ (no branch suffix) and HEAD_REF to an empty string. If the reports/ directory exists in the checked-out repo, the rm -rf "$BRANCH_REPORTS_DIR" command at line 39 will delete ALL test reports for ALL branches, not just a specific branch's reports. Previously, the pull_request: types: [closed] trigger ensured PR context was always available.

Prompt for agents
The cleanup-report.yml workflow was changed from a pull_request closed trigger to workflow_dispatch, but the job body still depends on github.event.pull_request.head.ref (lines 35-36). When triggered via workflow_dispatch, this context is empty, causing BRANCH_REPORTS_DIR to be just 'reports/' — which means rm -rf will delete ALL reports for every branch.

Options:
1. Restore the pull_request: types: [closed] trigger (keep workflow_dispatch and workflow_call as additional triggers)
2. If workflow_dispatch is needed, add a required input parameter for the branch name and use that when the PR context is missing
3. Add a guard that checks if HEAD_REF is non-empty before proceeding with deletion
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By design — this PR deliberately disables all automatic triggers to reduce Actions spend. The rm -rf command would only execute if manually triggered via workflow_dispatch, and the empty HEAD_REF means it would target reports/ which would be a no-op if the directory doesn't exist in the checkout. The workflow is effectively disabled from doing anything automatically.

workflow_call:
pull_request:
types: [closed]

permissions:
contents: write
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/cron-bookingReminder.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
name: Cron - bookingReminder

on:
workflow_dispatch:
# "Scheduled workflows run on the latest commit on the default or base branch."
# — https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#schedule
schedule:
# Runs "At every 15th minute." (see https://crontab.guru)
- cron: "*/15 * * * *"
jobs:
cron-bookingReminder:
env:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/cron-changeTimeZone.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
name: Cron - changeTimeZone

on:
workflow_dispatch:
# "Scheduled workflows run on the latest commit on the default or base branch."
# — https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#schedule
schedule:
# Runs "At every full hour." (see https://crontab.guru)
- cron: "0 * * * *"

jobs:
cron-scheduleEmailReminders:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/cron-checkSmsPrices.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
name: Cron - checkSmsPrices

on:
workflow_dispatch:
# "Scheduled workflows run on the latest commit on the default or base branch."
# — https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#schedule
schedule:
# Runs “every minute” (see https://crontab.guru)
- cron: "* * * * *"
jobs:
cron-checkSmsPrices:
env:
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/cron-downgradeUsers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ on:
workflow_dispatch:
# "Scheduled workflows run on the latest commit on the default or base branch."
# — https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#schedule
schedule:
# Runs "At 00:00 on day-of-month 1." (see https://crontab.guru)
- cron: "0 0 1 * *"
jobs:
cron-downgradeUsers:
env:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/cron-monthlyDigestEmail.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
name: Cron - monthlyDigestEmail

on:
workflow_dispatch:
# "Scheduled workflows run on the latest commit on the default or base branch."
# — https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#schedule
schedule:
# Runs on the 28th, 29th, 30th and 31st of every month (see https://crontab.guru)
- cron: "59 23 28-31 * *"
jobs:
cron-monthlyDigestEmail:
env:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/cron-scheduleEmailReminders.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,9 @@
name: Cron - scheduleEmailReminders

on:
workflow_dispatch:
# "Scheduled workflows run on the latest commit on the default or base branch."
# — https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#schedule
schedule:
# Runs "At every 15th minute." (see https://crontab.guru)
- cron: "*/15 * * * *"
jobs:
cron-scheduleEmailReminders:
env:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/cron-scheduleSMSReminders.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
name: Cron - scheduleSMSReminders

on:
workflow_dispatch:
# "Scheduled workflows run on the latest commit on the default or base branch."
# — https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#schedule
schedule:
# Runs "At every 15th minute." (see https://crontab.guru)
- cron: "*/15 * * * *"
jobs:
cron-scheduleSMSReminders:
env:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/cron-scheduleWhatsappReminders.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
name: Cron - scheduleWhatsappReminders

on:
workflow_dispatch:
# "Scheduled workflows run on the latest commit on the default or base branch."
# — https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#schedule
schedule:
# Runs "At every 15th minute." (see https://crontab.guru)
- cron: "*/15 * * * *"
jobs:
cron-scheduleWhatsappReminders:
env:
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/cron-stale-issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ permissions:
on:
# "Scheduled workflows run on the latest commit on the default or base branch."
# — https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#schedule
schedule:
# Runs "At 00:00." every day (see https://crontab.guru)
- cron: "0 0 * * *"
workflow_dispatch:
jobs:
stale:
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/cron-syncAppMeta.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ on:
workflow_dispatch:
# "Scheduled workflows run on the latest commit on the default or base branch."
# — https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#schedule
schedule:
# Runs "At 00:00 on day-of-month 1." (see https://crontab.guru)
- cron: "0 0 1 * *"
jobs:
cron-syncAppMeta:
env:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/cron-webhooks-triggers.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
name: Cron - webhookTriggers

on:
workflow_dispatch:
# "Scheduled workflows run on the latest commit on the default or base branch."
# — https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#schedule
schedule:
# Runs “every minute” (see https://crontab.guru)
- cron: "* * * * *"
jobs:
cron-webhookTriggers:
env:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/delete-blacksmith-cache.yml
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 delete-blacksmith-cache.yml: delete-cache-build-on-pr-close job is unreachable — PR caches are never cleaned

The pull_request: types: [closed] trigger was removed (lines 9-10 on the left), but the delete-cache-build-on-pr-close job at line 22 still checks if: github.event_name == 'pull_request' && github.event.action == 'closed'. Since workflow_dispatch is now the only trigger, this condition can never be true, and the job is dead code. Build caches (prod-build-*) for closed PRs will never be cleaned up, leading to cache accumulation.

(Refers to line 22)

Prompt for agents
The delete-blacksmith-cache.yml workflow lost its pull_request: types: [closed] trigger, but the delete-cache-build-on-pr-close job (line 22) still checks for github.event_name == 'pull_request'. This condition can never be true with only workflow_dispatch as a trigger.

This means build caches for closed PRs will never be cleaned up, leading to cache accumulation over time.

The pull_request: types: [closed] trigger should be restored alongside workflow_dispatch to preserve the automatic cleanup behavior.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By design — this PR deliberately disables all automatic triggers to reduce Actions spend. The dead pull_request condition is expected since the workflow is no longer auto-triggered on PR close events.

Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
description: "Blacksmith Cache Key to Delete"
required: true
type: string
pull_request:
types: [closed]

jobs:
manually-delete-blacksmith-cache:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/i18n.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
name: Run i18n AI automation
on:
push:
branches:
- main
workflow_dispatch:
concurrency:
group: ${{ github.workflow }}-main
cancel-in-progress: false
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/labeler.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
name: "Pull Request Labeler"
on:
pull_request_target:
workflow_dispatch:
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/nextjs-bundle-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@ name: "Next.js Bundle Analysis"
on:
workflow_call:
workflow_dispatch:
push:
branches:
- main

permissions:
actions: write
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/post-release.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
name: Post release
on:
workflow_dispatch:
push:
# Pattern matched against refs/tags
tags:
- "*"

permissions:
contents: write
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@
name: PR Update

on:
pull_request_target:
types: [opened, synchronize, reopened]
branches:
- main
- gh-actions-test-branch

workflow_dispatch:

Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/release-docker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ env:
DATABASE_HOST: "database:5432"

on:
push:
tags:
- "v*"
# in case manual trigger is needed
workflow_dispatch:
inputs:
RELEASE_TAG:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/run-ci.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
name: Run CI

on:
pull_request_target:
types: [labeled]
workflow_dispatch:
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 run-ci.yml: Job condition always false on workflow_dispatch — workflow is completely broken

The trigger was changed from pull_request_target: types: [labeled] to workflow_dispatch, but the trigger job's if condition on line 13 checks github.event.label.name == 'run-ci' || github.event.label.name == 'ready-for-e2e'. On a workflow_dispatch event, github.event.label does not exist, so this condition always evaluates to false. The job will never run, breaking the CI re-trigger mechanism for external contributors who need the run-ci label flow.

Prompt for agents
The run-ci.yml workflow was changed from pull_request_target: types: [labeled] to workflow_dispatch, but the job condition on line 13 still expects github.event.label.name from a label event. This field is never present in a workflow_dispatch event, so the trigger job can never execute.

This workflow is the mechanism for maintainers to approve CI runs for external contributors by adding the run-ci or ready-for-e2e label. With this change, that flow is completely broken.

The pull_request_target: types: [labeled] trigger needs to be restored for this workflow to function.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By design — this PR deliberately disables all automatic triggers to reduce Actions spend. The run-ci label flow is intentionally disabled. The workflow can be re-enabled by restoring the pull_request_target trigger if needed in the future.


permissions:
actions: write
Expand Down
7 changes: 1 addition & 6 deletions .github/workflows/semantic-pull-requests.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
name: "Validate PRs"

on:
pull_request_target:
types:
- opened
- reopened
- edited
- synchronize
workflow_dispatch:

permissions:
pull-requests: write
Expand Down
Loading