Skip to content

[main] feat: show workspace panel toggle on utility pages #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tomlord1122 merged 1 commit into from
Oct 19, 2026
Merged

[main] feat: show workspace panel toggle on utility pages #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions cometline/src/lib/features/shell/components/AppShell.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@
label={titlebarLabel}
renamable={titlebarRenamable}
titleAttr={titlebarSessionTitleAttr}
utilityPage={isUtilityPage}
{activeSessionId}
onRename={shortcuts.startRenameFromTitlebar}
/>
Expand Down Expand Up @@ -317,8 +316,7 @@
min-width: 72px;
}

/* Utility pages have their own page header and do not render the session
titlebar, while still keeping a usable main pane beside the workspace panel. */
/* Utility pages keep a usable main pane beside the workspace panel. */
.app-shell.utility-page:not(.is-fullscreen) .main {
min-width: 400px;
}
Expand Down
46 changes: 20 additions & 26 deletions cometline/src/lib/features/shell/components/ShellTitlebar.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,12 @@
label,
renamable,
titleAttr,
utilityPage,
activeSessionId,
onRename
}: {
label: string;
renamable: boolean;
titleAttr: string;
utilityPage: boolean;
activeSessionId: string | null;
onRename: () => void;
} = $props();
Expand Down Expand Up @@ -56,33 +54,29 @@
<span class="shell-titlebar-title">{label}</span>
{/if}
{/if}
{#if !utilityPage}
<div class="shell-titlebar-end">
<Tooltip
label={shellStore.workspacePanelOpen
<div class="shell-titlebar-end">
<Tooltip
label={shellStore.workspacePanelOpen ? 'Hide workspace panel' : 'Show workspace panel'}
action="toggleWorkspacePanel"
>
<button
type="button"
class="shell-titlebar-btn"
aria-label={shellStore.workspacePanelOpen
? 'Hide workspace panel'
: 'Show workspace panel'}
action="toggleWorkspacePanel"
aria-pressed={shellStore.workspacePanelOpen}
disabled={!activeSessionId}
onclick={() => shellStore.toggleWorkspacePanel()}
>
<button
type="button"
class="shell-titlebar-btn"
aria-label={shellStore.workspacePanelOpen
? 'Hide workspace panel'
: 'Show workspace panel'}
aria-pressed={shellStore.workspacePanelOpen}
disabled={!activeSessionId}
onclick={() => shellStore.toggleWorkspacePanel()}
>
{#if shellStore.workspacePanelOpen}
<PanelRightClose size={16} stroke-width={1.8} />
{:else}
<PanelRightOpen size={16} stroke-width={1.8} />
{/if}
</button>
</Tooltip>
</div>
{/if}
{#if shellStore.workspacePanelOpen}
<PanelRightClose size={16} stroke-width={1.8} />
{:else}
<PanelRightOpen size={16} stroke-width={1.8} />
{/if}
</button>
</Tooltip>
</div>
</header>

<style>
Expand Down
Loading