Skip to content

test(standalone): derive the fixture vendor id for every host architecture - #1503

Open
benceruleanlu wants to merge 1 commit into
mainfrom
bl/arm64-host-independent-tests
Open

benceruleanlu wants to merge 1 commit into
mainfrom
bl/arm64-host-independent-tests

Conversation

@benceruleanlu

@benceruleanlu benceruleanlu commented Sep 8, 2026

Copy link
Copy Markdown
Member

Part of a stack of review fixes for #1486, now merged. Based on main; #1504#1509 continue from this PR.

Summary

The standalone test fixture built its vendor id from the running host but appended the -arm64 suffix only on Windows. On a Linux ARM64 host it produced linux-nvidia, which the architecture filter added in #1486 now rejects, so seven release and variant tests failed there while passing on x64 CI.

Feature behavior

No product change. The fixture now mirrors variantMatchesHostArch: macOS bundles are unsuffixed ARM64, every other platform needs the suffix on an ARM64 host.

Test coverage and validation

  • A new guard test asserts the fixture id is one the host filter accepts, so a future divergence fails once with a message that names the cause, rather than as seven unrelated assertion failures.
  • Ran the file with process.platform and process.arch stubbed to win32/x64, win32/arm64, darwin/arm64, linux/x64 and linux/arm64: 49 tests pass in all five. Against the base branch, linux/arm64 fails 7.
  • Full unit suite: 274 files, 4736 passed, 2 skipped. Repeated with the whole suite stubbed as linux/arm64, same result.
  • Typecheck, lint and format all pass.

Change breakdown

Total changed lines: 20 (15 added, 5 deleted).

Product code

  • 0 files; +0 / -0; 0 changed lines; 0%.

Test code

  • 1 files; +15 / -5; 20 changed lines; 100.0% of total.
  • src/main/sources/standalone/index.test.ts

Documentation

  • 0 files; +0 / -0; 0 changed lines; 0%.

Configuration and CI

  • 0 files; +0 / -0; 0 changed lines; 0%.

Generated files

  • 0 files; +0 / -0; 0 changed lines; 0%.

Lockfiles

  • 0 files; +0 / -0; 0 changed lines; 0%.

Vendored code

  • 0 files; +0 / -0; 0 changed lines; 0%.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 42 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 463fc22f-8575-4e00-865c-eac339a01e03

📥 Commits

Reviewing files that changed from the base of the PR and between 3304521 and 718c06d.

📒 Files selected for processing (1)
  • src/main/sources/standalone/index.test.ts

Comment @coderabbitai help to get the list of available commands.

@benceruleanlu benceruleanlu changed the title test(standalone): derive the fixture vendor id for every host arch test(standalone): derive the fixture vendor id for every host architecture Sep 8, 2026
An error occurred while trying to automatically change base from codex/fix-linux-arm64-runtime-selection to main September 9, 2026 01:19
The fixture appended `-arm64` only on Windows, so on a Linux ARM64 host it
built `linux-nvidia` — an id the wizard's architecture filter now rejects.
Seven release/variant tests failed there while passing on x64 CI.

Mirror `variantMatchesHostArch` instead (macOS is unsuffixed ARM64; every
other platform needs the suffix on an ARM64 host) and add a guard test so a
future divergence fails once, with a message that names the cause.
@benceruleanlu
benceruleanlu force-pushed the bl/arm64-host-independent-tests branch from 5d27c5f to 718c06d Compare September 9, 2026 01:33
@benceruleanlu
benceruleanlu removed this pull request from stack #1510 September 9, 2026 01:34
@benceruleanlu
benceruleanlu changed the base branch from codex/fix-linux-arm64-runtime-selection to main September 9, 2026 01:34
@benceruleanlu
benceruleanlu added this pull request to stack #1513 September 9, 2026 01:34

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants