test(standalone): derive the fixture vendor id for every host architecture - #1503
Open
benceruleanlu wants to merge 1 commit into
Open
benceruleanlu wants to merge 1 commit into
benceruleanlu wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 42 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Comment |
An error occurred while trying to automatically change base from
codex/fix-linux-arm64-runtime-selection
to
main
September 9, 2026 01:19
The fixture appended `-arm64` only on Windows, so on a Linux ARM64 host it built `linux-nvidia` — an id the wizard's architecture filter now rejects. Seven release/variant tests failed there while passing on x64 CI. Mirror `variantMatchesHostArch` instead (macOS is unsuffixed ARM64; every other platform needs the suffix on an ARM64 host) and add a guard test so a future divergence fails once, with a message that names the cause.
benceruleanlu
force-pushed
the
bl/arm64-host-independent-tests
branch
from
September 9, 2026 01:33
5d27c5f to
718c06d
Compare
benceruleanlu
removed this pull request from stack #1510
September 9, 2026 01:34
benceruleanlu
changed the base branch from
codex/fix-linux-arm64-runtime-selection
to
main
September 9, 2026 01:34
benceruleanlu
added this pull request to stack #1513
September 9, 2026 01:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a stack of review fixes for #1486, now merged. Based on
main; #1504–#1509 continue from this PR.Summary
The standalone test fixture built its vendor id from the running host but appended the
-arm64suffix only on Windows. On a Linux ARM64 host it producedlinux-nvidia, which the architecture filter added in #1486 now rejects, so seven release and variant tests failed there while passing on x64 CI.Feature behavior
No product change. The fixture now mirrors
variantMatchesHostArch: macOS bundles are unsuffixed ARM64, every other platform needs the suffix on an ARM64 host.Test coverage and validation
process.platformandprocess.archstubbed to win32/x64, win32/arm64, darwin/arm64, linux/x64 and linux/arm64: 49 tests pass in all five. Against the base branch, linux/arm64 fails 7.Change breakdown
Total changed lines: 20 (15 added, 5 deleted).
Product code
Test code
Documentation
Configuration and CI
Generated files
Lockfiles
Vendored code