fix(linux): restore the ToDesktop platform-level resource fallback - #1504
Open
benceruleanlu wants to merge 1 commit into
Open
benceruleanlu wants to merge 1 commit into
benceruleanlu wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 42 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Comment |
A target list replaces the platform list rather than merging with it, and ToDesktop decides server-side which architectures a platform builds. With platformOverrides.linux gone, any Linux target outside the x64/arm64 keys falls through to the top-level list — ./lib alone — so the package ships without apparmor-profile and after-install.sh silently skips the AppArmor profile, leaving the sandbox blocked on Ubuntu 24.04+. Restore the fallback, mirroring the Windows shape, and add a test that holds it for every platform carrying per-target overrides.
benceruleanlu
force-pushed
the
bl/arm64-todesktop-linux-fallback
branch
from
September 9, 2026 01:33
b1cfbcc to
47b4b43
Compare
benceruleanlu
removed this pull request from stack #1510
September 9, 2026 01:34
benceruleanlu
added this pull request to stack #1513
September 9, 2026 01:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a stack of review fixes for #1486. Based on #1503.
Summary
#1486 replaced
platformOverrides.linuxwith per-architecturetargetOverrides, leaving Linux with no platform-level fallback while Windows keeps both. A ToDesktop target list replaces the platform list rather than merging with it, and ToDesktop decides server-side which architectures a platform builds, so any Linux target outside the x64 and arm64 keys now falls through to the top-level list:./libalone.Such a package ships without
resources/apparmor-profile.scripts/after-install.shthen fails itsapparmor_parserprobe, prints the misleading "this version of AppArmor does not support the bundled profile" message and skips installation, leaving the Electron sandbox blocked on Ubuntu 24.04 and later, with nothing failing at build time.Feature behavior
Restores
platformOverrides.linux, carrying the same three resources as the x64 target and sourcing bootstrap-python from the same staged directory. This mirrors the shape Windows already has. The per-target overrides are unchanged, so the architecture split #1486 introduced still applies wherever ToDesktop honours it.Test coverage and validation
Change breakdown
Total changed lines: 51 (45 added, 6 deleted).
Product code
Test code
Documentation
Configuration and CI
Generated files
Lockfiles
Vendored code