fix(bootstrap): skip hosts with no published bootstrap instead of failing - #1507
Open
benceruleanlu wants to merge 1 commit into
Open
benceruleanlu wants to merge 1 commit into
benceruleanlu wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 42 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Comment |
…ling detectPlatform threw on Linux ARM64, and both dev hooks called it unconditionally, so `pnpm run init` (install && bootstrap) and `pnpm run dev:bootstrap` died with a stack trace on that host — while `predev` pointed the developer at `pnpm run bootstrap`, the command that threw. No bootstrap for a host is a fact, not an error: the app falls back to system git. Return null for such hosts and report it, and give the script the two modes the hooks needed — --check (warn only) and --if-missing (build when absent). Both package.json one-liners now just call it, so the host-to-directory mapping they had each copied lives only in detectPlatform. An explicit --platform with an unknown name still fails.
benceruleanlu
force-pushed
the
bl/arm64-bootstrap-host-skip
branch
from
September 9, 2026 01:33
d2ebb5b to
4cb1068
Compare
benceruleanlu
removed this pull request from stack #1510
September 9, 2026 01:34
benceruleanlu
added this pull request to stack #1513
September 9, 2026 01:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a stack of review fixes for #1486. Based on #1506.
Summary
detectPlatformnow throws on Linux ARM64, and both dev hooks call it unconditionally.pnpm run init, which ispnpm install && pnpm run bootstrapand the command the README gives new contributors, dies with a stack trace on that host after installing.pnpm run dev:bootstrapdies the same way before Electron starts, andpredevpoints the developer atpnpm run bootstrap, the command that throws.A host with no published bootstrap is a fact rather than an error: the app falls back to system git.
Feature behavior
detectPlatformreturns null for such hosts, and every mode reports the situation and exits 0. The script gains the two modes the hooks needed,--checkto warn only and--if-missingto build when absent, so bothpackage.jsonone-liners now just call it. The host-to-directory mapping each of them had copied lives only indetectPlatform.An explicit
--platformnaming an unknown target still fails, so release builds, which always pass--platform, cannot silently skip.Test coverage and validation
Exercised the script with
process.platformandprocess.archstubbed:--check,--if-missingand no flag: prints "No bootstrap python is published for linux arm64" and exits 0.--check: prints the same warning as before and exits 0.--checkand--if-missingare silent, exit 0, and leave the directory untouched.--platformstill exits non-zero.Full unit suite: 274 files, 4736 passed, 2 skipped. Typecheck, lint and format pass. README updated for the skip.
Change breakdown
Total changed lines: 46 (37 added, 9 deleted).
Product code
Test code
Documentation
Configuration and CI
Generated files
Lockfiles
Vendored code