fix(git): stop telling packaged users to run a dev bootstrap command - #1508
Open
benceruleanlu wants to merge 1 commit into
Open
benceruleanlu wants to merge 1 commit into
benceruleanlu wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 42 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Comment |
A packaged app reaching this branch ships no bootstrap python for its platform — Linux ARM64 by design after this stack — but the warning claimed bootstrap-python/<platform>/ was missing and told the reader to run "pnpm run bootstrap". That lands in the user's log bundle once per launch, so a bug report built from it points at a packaging defect that isn't one, and names a command that doesn't exist for them (and now exits without building on that host anyway). Keep the developer hint for unpackaged runs; state the platform plainly in packaged ones.
benceruleanlu
force-pushed
the
bl/arm64-packaged-bootstrap-log
branch
from
September 9, 2026 01:33
90a4886 to
7f104b0
Compare
benceruleanlu
removed this pull request from stack #1510
September 9, 2026 01:34
benceruleanlu
added this pull request to stack #1513
September 9, 2026 01:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a stack of review fixes for #1486. Based on #1507.
Summary
After #1486 a packaged Linux ARM64 app ships a
bootstrap-pythondirectory holding only a README, sotryConfigureBootstrapPygit2returns false and the git backend falls through. The warning it logs claimsbootstrap-python/<platform>/is missing and tells the reader to runpnpm run bootstrap.That is developer guidance in an end user's log. It lands in the app log once per launch, so a bug report built from it points at a packaging defect that is not one, and names a command the user does not have. After #1507 that command exits without building on this host anyway.
Feature behavior
Unpackaged runs keep the existing hint, which is still correct for a developer who has not built the bootstrap. Packaged runs state the platform plainly and name the fallback. Behaviour is otherwise unchanged: the same fallback chain runs, and no telemetry is emitted on this path either way.
Test coverage and validation
app.isPackaged; no behavioural change to cover.Change breakdown
Total changed lines: 13 (10 added, 3 deleted).
Product code
Test code
Documentation
Configuration and CI
Generated files
Lockfiles
Vendored code