Skip to content

fix(git): stop telling packaged users to run a dev bootstrap command - #1508

Open
benceruleanlu wants to merge 1 commit into
bl/arm64-bootstrap-host-skipfrom
bl/arm64-packaged-bootstrap-log
Open

benceruleanlu wants to merge 1 commit into
bl/arm64-bootstrap-host-skipfrom
bl/arm64-packaged-bootstrap-log

Conversation

@benceruleanlu

@benceruleanlu benceruleanlu commented Sep 8, 2026

Copy link
Copy Markdown
Member

Part of a stack of review fixes for #1486. Based on #1507.

Summary

After #1486 a packaged Linux ARM64 app ships a bootstrap-python directory holding only a README, so tryConfigureBootstrapPygit2 returns false and the git backend falls through. The warning it logs claims bootstrap-python/<platform>/ is missing and tells the reader to run pnpm run bootstrap.

That is developer guidance in an end user's log. It lands in the app log once per launch, so a bug report built from it points at a packaging defect that is not one, and names a command the user does not have. After #1507 that command exits without building on this host anyway.

Feature behavior

Unpackaged runs keep the existing hint, which is still correct for a developer who has not built the bootstrap. Packaged runs state the platform plainly and name the fallback. Behaviour is otherwise unchanged: the same fallback chain runs, and no telemetry is emitted on this path either way.

Test coverage and validation

  • Log-message branch only, gated on app.isPackaged; no behavioural change to cover.
  • Full unit suite: 274 files, 4736 passed, 2 skipped. Typecheck, lint and format pass.

Change breakdown

Total changed lines: 13 (10 added, 3 deleted).

Product code

  • 1 files; +10 / -3; 13 changed lines; 100.0% of total.
  • src/main/lib/ipc/index.ts

Test code

  • 0 files; +0 / -0; 0 changed lines; 0%.

Documentation

  • 0 files; +0 / -0; 0 changed lines; 0%.

Configuration and CI

  • 0 files; +0 / -0; 0 changed lines; 0%.

Generated files

  • 0 files; +0 / -0; 0 changed lines; 0%.

Lockfiles

  • 0 files; +0 / -0; 0 changed lines; 0%.

Vendored code

  • 0 files; +0 / -0; 0 changed lines; 0%.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 42 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 4296844d-ab13-4f30-a1bd-6bf63779ff72

📥 Commits

Reviewing files that changed from the base of the PR and between 4cb1068 and 7f104b0.

📒 Files selected for processing (1)
  • src/main/lib/ipc/index.ts

Comment @coderabbitai help to get the list of available commands.

A packaged app reaching this branch ships no bootstrap python for its
platform — Linux ARM64 by design after this stack — but the warning claimed
bootstrap-python/<platform>/ was missing and told the reader to run
"pnpm run bootstrap". That lands in the user's log bundle once per launch,
so a bug report built from it points at a packaging defect that isn't one,
and names a command that doesn't exist for them (and now exits without
building on that host anyway).

Keep the developer hint for unpackaged runs; state the platform plainly in
packaged ones.
@benceruleanlu
benceruleanlu force-pushed the bl/arm64-packaged-bootstrap-log branch from 90a4886 to 7f104b0 Compare September 9, 2026 01:33
@benceruleanlu
benceruleanlu removed this pull request from stack #1510 September 9, 2026 01:34
@benceruleanlu
benceruleanlu added this pull request to stack #1513 September 9, 2026 01:34

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants