feat(install): say why ARM64 Linux has no local runtime - #1509
Open
benceruleanlu wants to merge 1 commit into
Open
benceruleanlu wants to merge 1 commit into
benceruleanlu wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughChangesHost architecture validation
Suggested reviewers: Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to Linux ARM64 hosts without a local runtime now receive a clear blocking message and cloud or remote alternative, while supported hosts continue through hardware validation. The change is covered by focused architecture-gate tests and has no remaining concrete merge-blocking risk. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Filtering every bundle out left getFieldOptions returning [], which reaches
the user as "No options available" and reaches telemetry as
express.fallback{precondition_failed} — the same as an empty or unreachable
catalog. The one state we know exactly was indistinguishable from the one we
do not.
Give the reason a home next to the filter that creates it and let
validateHardware report it, so ARM64 Linux takes the explain-and-block path
the wizard already gives an Intel Mac: a message naming the platform, and
express falling back with unsupported_hardware. Cloud and remote workspaces
are untouched — the wizard only blocks the standalone source card.
benceruleanlu
force-pushed
the
bl/arm64-unsupported-arch-state
branch
from
September 9, 2026 01:33
dd9ca39 to
25cad3e
Compare
benceruleanlu
removed this pull request from stack #1510
September 9, 2026 01:34
benceruleanlu
added this pull request to stack #1513
September 9, 2026 01:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a stack of review fixes for #1486. Based on #1508. Top of the stack.
Summary
#1486 correctly stops a Linux ARM64 app from selecting x64 bundles, but the resulting state is returned as a bare empty list. It reaches the user as "No options available" and telemetry as
express.fallbackwith reasonprecondition_failed, which is also what an empty or mis-published catalog produces. The one state we know exactly was indistinguishable from the one we do not, so a user cannot tell "wait for an ARM64 bundle" from "retry later", and metrics cannot separate this deliberate gap from a real catalog regression.Feature behavior
The reason now lives next to the filter that creates it, as
unsupportedHostReasoninenvPaths.ts, andvalidateHardwarereports it. Linux ARM64 therefore takes the explain-and-block path the wizard already gives an Intel Mac: a message naming the platform, and express install falling back withunsupported_hardware.Cloud and remote workspaces are unaffected. The wizard blocks only the standalone source card, and the message says so. No new i18n key or renderer plumbing is introduced; this reuses the existing hardware-validation mechanism end to end.
Removing the carve-out when
linux-*-arm64bundles ship is a one-function deletion. The architecture filter already accepts suffixed ids with no further change.Test coverage and validation
unsupportedHostReasonis tested against the filter it must agree with: on linux/arm64 no catalog id survivesvariantMatchesHostand a reason is returned; on win32/x64, win32/arm64, darwin/arm64 and linux/x64 at least one id survives and the reason is null. That pairing is what keeps the two from drifting apart.validateHardwareblocks on linux/arm64 with a message naming the platform and the cloud alternative, and does not gate linux/x64 on architecture.Change breakdown
Total changed lines: 92 (90 added, 2 deleted).
Product code
Test code
Documentation
Configuration and CI
Generated files
Lockfiles
Vendored code