This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Repository navigation
deps: dedupe runtime libraries - #6191
Merged
Merged
Conversation
legobeat
marked this pull request as ready for review
September 11, 2023 16:00
2 tasks done
cliffoo
approved these changes
Sep 11, 2023
This was referenced Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
dedupes various runtime libraries (a devDep or two might have snuck by but trying to keep this relatively scoped).
The impact on runtime of a fresh install without yarn cache (for example on a fresh developer environment) should be bigger than is visible in ci due to the dedupe of
keccak.Related
Testing instructions
Documentation
doc-change-requiredlabel to this PR if documentation updates are required.Breaking changes and new features
breaking-changeandnew-featurelabels for the appropriate packages.