Skip to content

Fix auth checks test fixture false positive #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seonghobae merged 1 commit into from
Jun 16, 2026
Merged

Fix auth checks test fixture false positive #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/test_vibesec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
},
{
"id": "mock-todo",
"pattern": re.compile(r"TODO: fix auth"),
"pattern": re.compile(r"TODO: fix issue"),
"severity": "HIGH",
"message": "Found auth todo",
"message": "Found issue todo",
"extensions": None,
},
{
Expand Down Expand Up @@ -81,7 +81,7 @@ def test_scan_file_with_findings(tmp_path):
@patch("scanner.cli.vibesec.SCAN_RULES", MOCK_RULES)
def test_scan_file_with_multiple_findings(tmp_path):
test_file = tmp_path / "unsafe_multiple.js"
test_file.write_text("const key = MOCK_SECRET_KEY;\n// TODO: fix auth checks here\n")
test_file.write_text("const key = MOCK_SECRET_KEY;\n// TODO: fix issue here\n")

findings = _scan_file(test_file, tmp_path)
rule_ids = [f["rule_id"] for f in findings]
Expand Down
Loading