🎨 Palette: [UX improvement] Hide decorative icons from screen readers#366
Conversation
Adds `aria-hidden="true"` to strictly decorative icons within `RoleSwitcher`, `SectionRoadmap`, and `Workspace` features. This prevents screen readers from redundantly announcing these icons since descriptive text equivalents are immediately adjacent to them.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
OpenCode Review Overview
Pull request overviewNo actionable findings or failed checks detected. CodeGraph structural exploration confirmed no issues. FindingsNo blocking findings from OpenCode's independent review. Verification
Gate evidence
|
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
No actionable findings or failed checks detected. CodeGraph structural exploration confirmed no issues.
Findings
No blocking findings from OpenCode's independent review.
Verification
- Review source: independent OpenCode review of the current checkout, focused changed hunks, and current-head GitHub Check evidence.
- Structural exploration: completed before approval; if structural exploration, changed-file inspection, or evidence completeness is missing, OpenCode must not approve.
- Result: APPROVE
- Reason: No source-backed blockers found and structural exploration was completed.
Gate evidence
- Head SHA:
46582315a3f13167d9d55886dea18d8344139daf - Workflow run: 27906451202
- Workflow attempt: 1
1 participant
💡 What: Added
aria-hidden="true"to several strictly decorativelucide-reacticons (Users, Lightbulb, Wand2, AlertCircle, and Download) across the Workspace feature components.🎯 Why: To improve accessibility for screen reader users by preventing redundant announcements when descriptive text is already present immediately adjacent to the icon.
📸 Before/After: The changes are entirely semantic and add an HTML attribute. Visually, there is zero change.
♿ Accessibility: Prevents screen readers from announcing ambiguous text for SVG icons next to labels.
PR created automatically by Jules for task 13221650668858260912 started by @seonghobae