Skip to content

🎨 Palette: [UX improvement] Hide decorative icons from screen readers #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Jun 21, 2026
+7 −7
Merged

🎨 Palette: [UX improvement] Hide decorative icons from screen readers #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/desktop/src/features/workspace/RoleSwitcher.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export function RoleSwitcher({ roles, activeRole, onRoleChange }: RoleSwitcherPr
return (
<div className="flex flex-col gap-4 py-2 sm:flex-row sm:items-center">
<div className="flex whitespace-nowrap text-sm font-semibold text-slate-200">
<Users className="mr-2 size-4 text-cyan-300" />
<Users className="mr-2 size-4 text-cyan-300" aria-hidden="true" />
{t("roleSwitcherTitle")}
</div>
<Tabs
Expand Down
6 changes: 3 additions & 3 deletions apps/desktop/src/features/workspace/SectionRoadmap.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,14 +165,14 @@ export function SectionRoadmap({ song, activeRole, onSongUpdate }: SectionRoadma

{role.setupNote && (
<div className="flex items-start gap-2 rounded-md border border-amber-300/20 bg-amber-300/[0.08] p-2 text-xs font-medium text-amber-100">
<Lightbulb className="mt-0.5 size-3.5 shrink-0" />
<Lightbulb className="mt-0.5 size-3.5 shrink-0" aria-hidden="true" />
<span className="leading-snug">{role.setupNote}</span>
</div>
)}

{role.simplification && (
<div className="flex items-start gap-2 rounded-md border border-indigo-300/20 bg-indigo-300/[0.08] p-2 text-xs font-medium text-indigo-100">
<Wand2 className="mt-0.5 size-3.5 shrink-0" />
<Wand2 className="mt-0.5 size-3.5 shrink-0" aria-hidden="true" />
<span className="leading-snug">{role.simplification}</span>
</div>
)}
Expand All @@ -181,7 +181,7 @@ export function SectionRoadmap({ song, activeRole, onSongUpdate }: SectionRoadma
<div className="mt-2 space-y-1.5">
{role.overlapWarnings.map((warning, wIdx) => (
<div key={wIdx} className="flex items-start gap-2 rounded-md border border-rose-300/20 bg-rose-300/[0.08] p-2 text-xs font-medium text-rose-100">
<AlertCircle className="mt-0.5 size-3.5 shrink-0" />
<AlertCircle className="mt-0.5 size-3.5 shrink-0" aria-hidden="true" />
<span className="leading-snug">{warning}</span>
</div>
))}
Expand Down
6 changes: 3 additions & 3 deletions apps/desktop/src/features/workspace/Workspace.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ export function Workspace({ song, sourceBootstrap = null, onSongUpdate }: Worksp
onClick={handleExportCueSheet}
className="min-h-10 border-cyan-300/30 bg-cyan-300/10 font-semibold text-cyan-50 shadow-[0_10px_30px_rgba(34,211,238,0.16)] hover:bg-cyan-300/20 hover:text-white"
>
<Download className="mr-2 size-4 text-cyan-200" />
<Download className="mr-2 size-4 text-cyan-200" aria-hidden="true" />
Export Cue Sheet (CSV)
</Button>
<Button
Expand All @@ -231,7 +231,7 @@ export function Workspace({ song, sourceBootstrap = null, onSongUpdate }: Worksp
onClick={handleExportChart}
className="min-h-10 border-white/10 bg-white/5 font-semibold text-slate-100 shadow-sm hover:bg-white/10 hover:text-white"
>
<Download className="mr-2 size-4 text-slate-300" />
<Download className="mr-2 size-4 text-slate-300" aria-hidden="true" />
Export Chart (JSON)
</Button>
<Button
Expand All @@ -240,7 +240,7 @@ export function Workspace({ song, sourceBootstrap = null, onSongUpdate }: Worksp
onClick={handleExportHandoff}
className="min-h-10 border-teal-300/25 bg-teal-300/10 font-semibold text-teal-50 shadow-sm hover:bg-teal-300/20 hover:text-white"
>
<Download className="mr-2 size-4 text-teal-200" />
<Download className="mr-2 size-4 text-teal-200" aria-hidden="true" />
Export Handoff (JSON)
</Button>
</div>
Expand Down