Skip to content

🔒 fix path traversal vulnerability #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seonghobae wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

🔒 fix path traversal vulnerability #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d68a49
🔒 fix path traversal vulnerability
seonghobae Jun 21, 2026
8f7f64a
🔒 fix path traversal vulnerability
seonghobae Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/workflows/opencode-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,6 +923,7 @@ jobs:
GH_TOKEN: ${{ steps.opencode_app_token.outputs.token || secrets.OPENCODE_APPROVE_TOKEN || github.token }}
OPENCODE_APP_TOKEN: ${{ steps.opencode_app_token.outputs.token }}
OPENCODE_APPROVE_TOKEN: ${{ secrets.OPENCODE_APPROVE_TOKEN }}
GITHUB_TOKEN: ${{ github.token }}
GH_REPOSITORY: ${{ github.repository }}
PR_NUMBER: ${{ github.event.pull_request.number || github.event.inputs.pr_number }}
HEAD_SHA: ${{ github.event.pull_request.head.sha || github.event.inputs.pr_head_sha }}
Expand Down Expand Up @@ -1035,6 +1036,7 @@ jobs:
STRIX_GITHUB_MODELS_TOKEN: ${{ secrets.STRIX_GITHUB_MODELS_TOKEN }}
OPENCODE_APP_TOKEN: ${{ steps.opencode_app_token.outputs.token }}
OPENCODE_APPROVE_TOKEN: ${{ secrets.OPENCODE_APPROVE_TOKEN }}
GITHUB_TOKEN: ${{ github.token }}
OPENCODE_EVIDENCE_FILE: ${{ runner.temp }}/opencode-review-evidence.md
OPENCODE_FAILED_CHECK_EVIDENCE_FILE: ${{ runner.temp }}/opencode-failed-check-evidence.md
OPENCODE_FAILED_CHECK_DIAGNOSIS_FILE: ${{ runner.temp }}/opencode-failed-check-diagnosis.md
Expand Down Expand Up @@ -2072,11 +2074,22 @@ jobs:
local attempts="${CHECK_LOOKUP_RETRY_ATTEMPTS:-5}"
local sleep_seconds="${CHECK_LOOKUP_RETRY_SLEEP_SECONDS:-5}"
local attempt=1
local stderr_file
stderr_file="$(mktemp)"

while [ "$attempt" -le "$attempts" ]; do
if "$collector" "$output_file"; then
if "$collector" "$output_file" 2>"$stderr_file"; then
rm -f "$stderr_file"
return 0
fi
cat "$stderr_file" >&2
if grep -q "HTTP 401" "$stderr_file"; then
if [ -n "${OPENCODE_APPROVE_TOKEN:-}" ]; then
export GH_TOKEN="$OPENCODE_APPROVE_TOKEN"
elif [ -n "${GITHUB_TOKEN:-}" ]; then
export GH_TOKEN="$GITHUB_TOKEN"
fi
fi
: >"$output_file"
if [ "$attempt" -lt "$attempts" ]; then
printf 'GitHub Checks lookup failed; retrying %s/%s before changing review state.\n' "$attempt" "$attempts" >&2
Expand All @@ -2085,6 +2098,7 @@ jobs:
attempt=$((attempt + 1))
done

rm -f "$stderr_file"
return 1
}

Expand Down
4 changes: 2 additions & 2 deletions services/analysis-engine/src/bandscope_analysis/separation/audio_separator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def separate(self, audio_path: str | Path) -> AudioSeparationResult:

def _resolve_audio_file(self, audio_path: str | Path) -> Path:
"""Normalize and validate the selected source path."""
candidate = Path(audio_path).expanduser()
candidate = Path(audio_path)
try:
path = candidate.resolve(strict=True)
except FileNotFoundError as error:
Expand Down Expand Up @@ -215,7 +215,7 @@ def _load_model_profile(self) -> dict[str, float]:
expected_sha256 = _BANDSPLIT_PROFILE_SHA256

if self.config.model_profile_path:
profile_candidate = Path(self.config.model_profile_path).expanduser()
profile_candidate = Path(self.config.model_profile_path)
try:
profile_path = profile_candidate.resolve(strict=True)
except FileNotFoundError as error:
Expand Down
Loading