Skip to content

Size the pager backdrop to the full-bleed page height #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShawnMadadha wants to merge 1 commit into from
Closed

Size the pager backdrop to the full-bleed page height #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion App/Continuity/Views/MainPagerView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@ struct MainPagerView: View {
// insets are re-applied per page below.
GeometryReader { proxy in
let insets = proxy.safeAreaInsets
let pageHeight = proxy.size.height
// The GeometryReader sits INSIDE the safe area, but the pages tile the full-bleed
// viewport (the ScrollView ignores the safe area) — so the true page height is the
// measured height plus both insets. Using proxy.size.height alone leaves the shared
// backdrop half-an-inset short at each end of every page (dark bands at the status
// bar and home indicator on Now Playing).
let pageHeight = proxy.size.height + insets.top + insets.bottom
ScrollView(.vertical) {
// Every page gets HARD insets (the pager hides the window safe area, and
// neither NavigationStack bars nor safe-area piercing behave inside scroll
Expand Down
Loading