Repository navigation
Size the pager backdrop to the full-bleed page height - #142
Closed
ShawnMadadha wants to merge 1 commit into
Closed
ShawnMadadha wants to merge 1 commit into
ShawnMadadha wants to merge 1 commit into
Conversation
The shared PagerBackdrop was sized from the GeometryReader's height, which is measured inside the safe area — but the pages it sits behind tile the full-bleed viewport (the ScrollView ignores the safe area). The backdrop came up one safe-area short over three pages and was centered behind the content, leaving ~half-an-inset dark band at the status bar and home indicator on Now Playing. Add both insets back to the measured height so the backdrop covers the pages exactly.
Collaborator
|
never cook again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Now Playing, the album gradient stops short of the screen edges — dark bands (~46pt, half the safe-area insets) at the status bar and above the home indicator instead of the backdrop blending seamlessly into them.
Root cause
MainPagerViewmeasurespageHeightfrom its GeometryReader, which sits inside the safe area — but the pages are sized bycontainerRelativeFrameagainst the full-bleed scroll viewport (the ScrollView ignores the safe area). The sharedPagerBackdroptherefore spans three too-short pages and gets centered behind the taller content, leaving half-an-inset of uncovered flat background at each end of every page.Fix
pageHeight = proxy.size.height + insets.top + insets.bottom— the true tiled page height. One line plus a comment explaining the geometry so it doesn't regress.Verification
Built and launched on the iPhone 17 Pro Max simulator (iOS 26): the gradient now runs edge-to-edge behind the status bar and home indicator with no bands or seams.
🤖 Generated with Claude Code