Skip to content

NEWS: code-hygiene entry for #224, with thanks to the contributor - #240

Merged
feralaes merged 1 commit into
mainfrom
news-224-code-hygiene
Nov 13, 2026
Merged

feralaes merged 1 commit into
mainfrom
news-224-code-hygiene

Conversation

@feralaes

Copy link
Copy Markdown
Collaborator

Adds the NEWS entries for the outside contribution in #224 (issue #211). Please merge this right after #224.

  1. Breaking changes: dampack now requires ggplot2 ≥ 3.5.0 and scales ≥ 1.3.0. Code hygiene: qualified imports, modern ggplot2/scales APIs, seq_len loops, closed progress bars (#211) #224 raised both lower bounds.
  2. Bug fixes: a summary of Code hygiene: qualified imports, modern ggplot2/scales APIs, seq_len loops, closed progress bars (#211) #224's code-hygiene changes, thanking its author. As requested, the thanks appears only here, in NEWS. It uses the tidyverse (@handle, #PR) convention, and GitHub doesn't send notifications for handles inside files.

This is a separate PR because #224 lives on the contributor's fork, where I didn't push.

Mergeable in any order: each open PR's NEWS bullet now sits at its own position, so no two PRs touch the same lines. I simulated merging all ten open PRs (#224, #227, #233–#239, and this one) into main in several different orders. Every order merges cleanly and produces the identical final tree, and all tests pass on the combined code.

@feralaes
feralaes merged commit 8a9bea9 into main Nov 13, 2026
9 checks passed
@feralaes
feralaes deleted the news-224-code-hygiene branch November 13, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant