Skip to content

feat(ranking): build persisted monthly rankings - #19

Merged
DAVstudy merged 1 commit into
feat/t11-audit-persistencefrom
feat/t11-persisted-ranking
Nov 16, 2026
Merged

DAVstudy merged 1 commit into
feat/t11-audit-persistencefrom
feat/t11-persisted-ranking

Conversation

@DAVstudy

@DAVstudy DAVstudy commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Closes #10

Summary

  • Build a store-scoped monthly ranking from persisted tournaments.
  • Reuse existing scoring rules for placement, invitations, and weekly continuity.
  • Apply only the latest valid audited tie-resolution revision while preserving points.

Changes

File Change
src/modules/ranking/build-store-monthly-ranking.ts Composes persisted tournament data into the protected monthly ranking and applies audited tie readback.
src/modules/ranking/build-store-monthly-ranking.test.ts Covers store/month isolation, scoring bonuses, continuity, and latest-revision readback.
src/modules/ranking/resolve-top-cut-tie.ts Exposes resolver contracts needed by the application layer.

Test plan

  • Focused ranking tests pass: 5/5.
  • TypeScript typecheck passes.
  • Full Vitest suite passes.
  • Independent high-risk verification passes.
  • Native review approved and acknowledged.

Contributor checklist

  • Linked an approved issue.
  • Added exactly one type:* label.
  • No shell scripts changed; shellcheck is not applicable.
  • Behavior is covered by focused and full-suite tests.
  • Documentation is included in the final chain slice.
  • Commits use Conventional Commit format.
  • No Co-Authored-By trailers.

Chain Context

Field Value
Chain T11 persisted monthly ranking
Tracker PR Not needed
Position 2 of 3
Base feat/t11-audit-persistence
Depends on #18
Follow-up #20
Review budget 524 / 400 — approved size:exception; ranking behavior and its tests form one cohesive unit
Starts at Audited tie-resolution persistence from #18
Ends with Reproducible store/month ranking and latest-resolution readback

Chain Overview

main
 └── #18 Audited tie-resolution persistence
      └── 📍 #19 Persisted monthly ranking
           └── #20 Tie-resolution application flow and docs

Scope

  • Includes: persisted ranking composition, scoring bonuses, continuity, and audited readback.
  • Excludes: the organizer command that records a tie resolution.

Autonomy

  • CI is expected to pass for this PR branch.
  • This PR has one deliverable scope.
  • This PR can be rolled back without unrelated changes.
  • Tests cover this unit.

@DAVstudy DAVstudy added the type:feature Nueva funcionalidad label Nov 16, 2026
@DAVstudy
DAVstudy merged commit 3d24096 into feat/t11-audit-persistence Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature Nueva funcionalidad

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant