-
Notifications
You must be signed in to change notification settings - Fork 4
Fix relations drawn on non existent notes #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Crowerade I'm afraid that even after a580a98 and a4f9eab (i.e. the last two commits), creating a meta-relation with relations that are reduced out in other layers still causes a crash. I tested with |
|
I tried reproducing it, but it worked fine. Could you tell what steps you followed to have the crash? |
|
@Crowerade to reproduce, perhaps you need to create a meta-relation with two relations, only one of which has been reduced-out in the second layer. The other relation in this test existed in both layers. (I repeated the test again just now to be sure.) |
|
That's curious, it does not emit any error |
|
@Crowerade I sent you a screencap via Mattermost reproducing the bug. |
|
This should be fixed |
|
@Crowerade this is good, thanks. Unfortunately our predicament with layers continue: un-reducing the added layer (thus adding back the previously removed notes) fails to show the new relations and meta-relations that involved them. Sent you a video on Mattermost to clarify. |
|
Essentially, whenever we un-reduce, after putting back all relevant notes we should have a second step to add any graph (meta-)relations that became renderable. |
|
I'll look into that |
|
This is not planned in the end since we want to have static layers instead of dynamic and updatable ones |
Addresses #379