Skip to content

Conversation

@Crowerade
Copy link
Collaborator

Addresses #379

@Crowerade Crowerade requested a review from yrammos August 13, 2025 13:36
@Crowerade Crowerade self-assigned this Aug 13, 2025
@Crowerade Crowerade added the bug Something isn't working label Aug 13, 2025
@Crowerade Crowerade changed the base branch from master to develop August 13, 2025 13:37
@yrammos
Copy link
Member

yrammos commented Aug 13, 2025

@Crowerade I'm afraid that even after a580a98 and a4f9eab (i.e. the last two commits), creating a meta-relation with relations that are reduced out in other layers still causes a crash. I tested with minimal_analysis_2.mei.

@Crowerade
Copy link
Collaborator Author

I tried reproducing it, but it worked fine. Could you tell what steps you followed to have the crash?

@yrammos
Copy link
Member

yrammos commented Aug 14, 2025

@Crowerade to reproduce, perhaps you need to create a meta-relation with two relations, only one of which has been reduced-out in the second layer. The other relation in this test existed in both layers.

(I repeated the test again just now to be sure.)

@Crowerade
Copy link
Collaborator Author

That's curious, it does not emit any error

@yrammos
Copy link
Member

yrammos commented Aug 14, 2025

@Crowerade I sent you a screencap via Mattermost reproducing the bug.

@Crowerade
Copy link
Collaborator Author

This should be fixed

@yrammos
Copy link
Member

yrammos commented Aug 14, 2025

@Crowerade this is good, thanks.

Unfortunately our predicament with layers continue: un-reducing the added layer (thus adding back the previously removed notes) fails to show the new relations and meta-relations that involved them.

Sent you a video on Mattermost to clarify.

@yrammos
Copy link
Member

yrammos commented Aug 14, 2025

Essentially, whenever we un-reduce, after putting back all relevant notes we should have a second step to add any graph (meta-)relations that became renderable.

@Crowerade
Copy link
Collaborator Author

I'll look into that

@yrammos yrammos removed their request for review August 14, 2025 13:46
@Crowerade
Copy link
Collaborator Author

This is not planned in the end since we want to have static layers instead of dynamic and updatable ones

@Crowerade Crowerade closed this Aug 15, 2025
@yrammos yrammos added the wontfix This will not be worked on label Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Relations are drawn on all layers, regardless of the existence of the participating notes

3 participants