fix(bed-fit): keep object size and placed bounds apart (#91)

CHANGELOG.md

@@ -10,6 +10,7 @@ All notable changes to this project are documented here. The format is based on
 - **Print risk signals replace the readiness percentage.** The "Print readiness (estimate)" percentage, the star rating and the Studio score are gone. Studio now lists each risk it found, once per condition, with what it means and what to do, and says what it did and did not check. Community guidance attaches only to the conditions it actually fits.
 
 ### Fixed
+- Bed fit now reports each object's size and the instances' placement as separate facts; several small, separated objects are no longer summed into one "too big" object (#91).
 - Object placement judges each placed copy of a repeated object on its own, so a copy that hangs off the plate is no longer hidden by one that does not (#93).
 - Placement and plate-fit checks are withheld (reported as not checked) for projects whose physical size the file does not establish: a non-millimetre unit, or a rotated or scaled object.
 

backend/snapstudio_api/service.py

@@ -496,7 +496,7 @@ def diff(a: str, b: str) -> dict:
 def insights(path: str) -> dict:
     """Rich read-only Project Intelligence (geometry, materials, readiness)."""
     from snapstudio_core.intelligence import project_info
-    return project_info(path)
+    return project_info(path, placement_aware=True)
 
 
 def report(path: str) -> dict:
@@ -2077,12 +2077,14 @@ def mm_doctor(path: str, host: str | None = None, port: int = 7125, snapshot: di
 
 
 def bed_fit(path: str, host: str | None = None, port: int = 7125, snapshot: dict | None = None) -> dict:
-    """Bed-Fit / Out-of-Bounds Doctor: does the model fit the U1 bed, and if not,
-    WHY (the cryptic 'out of bounds' error) and HOW to fix it. Uses the connected
-    U1's real bed when reachable, else the known U1 bed. Read-only; works offline."""
+    """Bed-Fit / Out-of-Bounds Doctor: does each object fit the printer's printable area (by size),
+    do the placed instances sit on it (by placement), and if not, WHY (the cryptic 'out of bounds'
+    error) and HOW to fix it. Uses the profile of the connected printer when it identifies itself,
+    else the known U1 profile; a connected printer Studio cannot identify is reported as unknown.
+    Read-only; works offline."""
     from snapstudio_core.intelligence import project_info
     from snapstudio_core import bed_fit as bf
-    info = project_info(path)
+    info = project_info(path, placement_aware=True)
     basis = info.get("geometry_basis")
     if not geometry_basis.is_established(basis):
         # The numbers in the file are not the physical size: say "not checked", never "fits".
@@ -2093,12 +2095,46 @@ def bed_fit(path: str, host: str | None = None, port: int = 7125, snapshot: dict
     multi = (info.get("colors") or 0) > 1
     bed = None
     bed_known = False
-    caps = _caps(host, port, snapshot)
-    bm = (caps or {}).get("bed_mm")
-    if bm and bm.get("x"):
-        bed, bed_known = bm, True
-    return bf.assess(dims, bed=bed, bed_known=bed_known,
-                     object_count=object_count, multi_material=multi)
+    # Offline: the machine Studio prepares for (its profile polygon). Connected: the printable area of
+    # the printer that identifies itself; a printer's reported bed is axis TRAVEL (about 271 x 335 on a
+    # U1, anchored at 0,0), never used as a printable rectangle or size, so a printer Studio cannot
+    # identify gets neither a size nor a placement verdict.
+    target = _placement_target({"identity": {"printer_id": printer_profiles_target_id()}})
+    profile = None
+    if host:
+        from snapstudio_core import printer_profiles
+        target = None
+        try:
+            caps = _caps(host, port, snapshot)
+            if caps is None:
+                raise RuntimeError("printer unreachable")   # fall back to the profile Studio prepares for
+            identity = printer_profiles.identify({"reachable": True,
+                                                  "klipper_objects": caps.get("klipper_objects"),
+                                                  "toolhead_count": caps.get("toolhead_count")})
+            target = _placement_target({"identity": identity})
+            if identity.get("printer_id"):
+                # the identified printer's RECORDED printable volume, labelled as the profile's, not as
+                # something the printer measured
+                profile = printer_profiles.load(identity["printer_id"])
+            else:
+                # a printer Studio cannot identify reports axis travel, not a printable size: neither
+                # the size nor the placement can be judged
+                return {"schema_version": bf.SCHEMA_VERSION, "available": False, "basis": "size",
+                        "reason": ("Studio does not know this connected printer's printable area (it "
+                                   "reports axis travel, which is not a printable size), so it cannot say "
+                                   "whether the objects fit.")}
+        except Exception:
+            target = _placement_target({"identity": {"printer_id": printer_profiles_target_id()}})
+    # Two separate facts: how big each object is (size, per object) and where the instances sit
+    # (placement, per instance and plate). A combined extent is neither, and is never used here.
+    try:
+        placed = _assess_against(path, target)
+    except Exception:
+        placed = None
+    return bf.assess_objects(info.get("object_sizes_mm"), placed=placed,
+                             unmeasured=info.get("objects_unmeasured") or 0,
+                             bed=bed, bed_known=bed_known, profile=profile, object_count=object_count,
+                             multi_material=multi)
 
 
 def _printer_snapshot(host: str, port: int = 7125, limit: int = 50) -> dict:
@@ -2691,6 +2727,12 @@ def batch_status(job_id: str) -> dict | None:
 _ready_cache_lock = threading.Lock()
 
 
+def printer_profiles_target_id() -> str:
+    from snapstudio_core import printer_profiles
+
+    return printer_profiles.PREPARE_TARGET_ID
+
+
 def _placement_target(facts: dict) -> dict | None:
     """The printable area to judge placement against, or None when it is not known.