Repository navigation
feat(prepare): per-plate regrid, prime-tower placement, kept support intent #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DVOpenLabs
wants to merge
2
commits into
main
Choose a base branch
from
fix/plate-regrid-tower
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: DVOpenLabs/snapmaker-studio
Length of output: 4578
🏁 Script executed:
Repository: DVOpenLabs/snapmaker-studio
Length of output: 21431
🏁 Script executed:
Repository: DVOpenLabs/snapmaker-studio
Length of output: 18690
Keep XML item enumeration consistent with
geometry.build_items.A reachable valid multi-plate model can contain a prefixed core item with printable geometry followed by an unprefixed item whose object has no points.
measure_itemsskips the later item, so_plan_regridcreates only the earlier item’s offset.rewrite_items_by_indexthen treats the later unprefixed tag as ordinal0, applies the earlier offset to it, and returnsmoved == len(offsets)._apply_offsetsaccepts the rewrite.The printable item remains at its source-grid position, which can leave its geometry on the wrong target plate cell. Match prefixed core item tags at the enumeration boundary:
Suggested fix
When both items are measured and planned, the existing moved-count guard correctly rejects the mismatch because fewer tags are rewritten than offsets exist. It also rejects cases where the offset keys do not match the writer’s ordinals.
🤖 Prompt for AI Agents