Repository navigation
Correct Ally press-test paddle sides and restore inputplumber - #81
Merged
DanielJBurbridge merged 1 commit intoNov 17, 2026
Conversation
M2 is the left back paddle and M1 is the right. The capture stops inputplumber.service and starts it again afterwards if it was active. Volume keys come from the AT Translated Set 2 keyboard, found by name. The 17 Nov readings are recorded as pending a re-run. L230. Model: grok-4.7 Co-authored-by: Daniel Burbridge <DanielJBurbridge@users.noreply.github.com>
DanielJBurbridge
left a comment
Owner
Author
There was a problem hiding this comment.
dev-red review: PASS at f5a65c9
- The trap is installed before
inputplumberis stopped, and it only restarts the unit if it was active, once (IP_RESTORED). INT exits with 130 and TERM with 143. If the stop fails, the script exits before the capture. VOLis found by name, and an empty device is skipped. M2/M1 sides match the 17 Nov results in every doc this touches.bash -nandally-press-script-testpass locally. Integ a1fc4bb is an ancestor of this head. There's a Model trailer (grok-4.7). Nothing is removed from the follow-ups.- Actions
testis green.
Low follow-up (L230 range): add HUP to the traps. This tool is run over ssh rog-ally. If the SSH session drops mid-capture, the shell gets SIGHUP, which isn't trapped, so inputplumber stays stopped and the pad loses its greeter pointer until reboot or a manual systemctl start. trap 'restore_capture; exit 129' HUP fixes it.
Cleared to merge at this sha.
DanielJBurbridge
merged commit Nov 17, 2026
e9fca47
into
feat/ally-parity-integration-20261111
1 check passed
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The Ally button-capture script labelled M1 as the left back paddle and M2 as the right. M2 is the left paddle and M1 is the right. Prompts in
docs/handheld/research/tools/ally-press-test.shand the same side labels in the handheld docs are corrected.The script now stops
inputplumber.servicebefore the capture and starts it again on EXIT, INT and TERM, only if that unit was active, and the trap runs the restart once. Volume keys are read from theAT Translated Set 2 keyboard, found by name in/proc/bus/input/devices, not from a fixed event node.Daniel's 17 Nov RC71L readings are recorded in
docs/handheld/01-controller-button-map.mdas observed with inputplumber stopped, pending a re-run with this script: M2 (left) sent F15, M1 (right) sent nothing, A was not reported while a paddle was held, and a 1 s Command Centre hold sent nothing.Claims L230–L239. L230 is the re-run.
Model: grok-4.7
Verification
bash test/shell.d/ally-press-script-test.shpassed:bash -non the script, the paddle prompts name M2 on the left and M1 on the right, and the trap stops and restartsinputplumber.service.Not run on the Ally. The 17 Nov readings are from the previous script and stay pending a re-run.
Screenshots
No visible change: research script and docs only. The desktop shell is untouched.