Repository navigation
Fix four Ally lows: config home, sudoers mode, update path, press-test HUP - #83
Merged
DanielJBurbridge merged 5 commits intoNov 17, 2026
Conversation
The shell-down check looked only at ~/.config, so a custom config home hid the button. Model: grok-4.7 Co-authored-by: Daniel Burbridge <DanielJBurbridge@users.noreply.github.com>
install -D was recording /etc/sudoers.d as 0755, which pacman warns differs from the filesystem's 0750. Model: grok-4.7 Co-authored-by: Daniel Burbridge <DanielJBurbridge@users.noreply.github.com>
A non-login ssh command does not source env-bootstrap, so set -u aborted omarchy-i18n and the next update steps. Model: grok-4.7 Co-authored-by: Daniel Burbridge <DanielJBurbridge@users.noreply.github.com>
SIGHUP does not run the EXIT trap, so a dropped session left inputplumber stopped. The HUP trap uses the same one-shot restore. Model: grok-4.7 Co-authored-by: Daniel Burbridge <DanielJBurbridge@users.noreply.github.com>
1.0.0-7 already shipped in #84. The sudoers directory mode still needs a new release. L244–247 record the open review items and do not implement them. Model: grok-4.7 Co-authored-by: Daniel Burbridge <DanielJBurbridge@users.noreply.github.com>
cursor
Bot
force-pushed
the
fix/ally-lows-20261117
branch
from
November 17, 2026 04:24
0146e17 to
cacbd35
Compare
DanielJBurbridge
left a comment
Owner
Author
There was a problem hiding this comment.
dev-red: PASS at cacbd35 (Model: grok-4.7)
- integ bbaac86 is an ancestor of the head; no '-' lines in alpha-followups.
- All 5 commits carry
Model: grok-4.7. - Actions
testandi18n-checkare green on cacbd35. - XDG_CONFIG_HOME read is still read-only (jq check only, no shell.json write).
install -dm750 etc/sudoers.dmatches sudo's mode; pkgrel 8 resolves the #84 collision; only the PKGBUILD changed, so the unchanged sums are right.- OMARCHY_PATH fallback matches omarchy-migrate (
/usr/share/omarchy). - HUP trap restores inputplumber and the EXIT trap is a no-op afterwards.
Low (no follow-up needed unless you want one): a dev checkout updated over a non-login ssh command now silently skips omarchy-update-dev instead of aborting, because unset OMARCHY_PATH falls back to the packaged tree. Better than the set -u abort, but worth a line in HANDOFF to export OMARCHY_PATH for dev checkouts.
DanielJBurbridge
merged commit Nov 17, 2026
d0d40b9
into
feat/ally-parity-integration-20261111
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Four small fixes, one commit each, on top of
e9fca470(merged #81). Claims follow-up range L240–L249. L240–L243 are the items below. L244–L249 are reserved and empty.keyboard_button_in_shellreads${XDG_CONFIG_HOME:-$HOME/.config}instead of a hardcoded~/.config, so a stopped shell still names a Keyboard button that lives in a custom config home.omarchy-gaming-sessioncreates/etc/sudoers.dwithinstall -dm750(pkgrel 7).install -Dhad recorded the directory as 0755, and pacman warned that it differed from the filesystem's 0750.default/does not shipsudoers.d.omarchy-settingsstill copiesetc/from omarchy-pkgs, which is outside this tree.omarchy updateno longer dies withOMARCHY_PATH: unbound variable.omarchy-i18n,omarchy-update-devandomarchy-update-keyringdefault it to/usr/share/omarchy, the same fallback asenv-bootstrapandomarchy-migrate.omarchy-updateexports that default for the rest of the update path.restore_captureand exits 129. An SSH drop does not run EXIT, soinputplumber.servicestayed stopped.IP_RESTOREDstill makes the following EXIT trap return without starting the service again.Model: grok-4.7
Verification
bash test/shell.d/i18n-test.shpassed, including an unsetOMARCHY_PATH.bash test/shell.d/update-dev-test.shpassed, including an unsetOMARCHY_PATHskipping the dev checkout.bash test/shell.d/update-keyring-test.shpassed.bash test/shell.d/ally-press-script-test.shpassed, including the HUP trap line andbash -n.test/shell.d/hw-rog-ally-test.shandtest/shell.d/handheld-autologin-test.shdid not finish here: this host has nosystemd-hwdband nonewuidmap. Those assertions run in the Tests workflow VM.Screenshots
No visible change: command defaults, a package directory mode, and a research-script signal trap.