Skip to content

Fix four Ally lows: config home, sudoers mode, update path, press-test HUP - #83

Merged
DanielJBurbridge merged 5 commits into
feat/ally-parity-integration-20261111from
fix/ally-lows-20261117
Nov 17, 2026
Merged

DanielJBurbridge merged 5 commits into
feat/ally-parity-integration-20261111from
fix/ally-lows-20261117

Conversation

@DanielJBurbridge

Copy link
Copy Markdown
Owner

What changes

Four small fixes, one commit each, on top of e9fca470 (merged #81). Claims follow-up range L240–L249. L240–L243 are the items below. L244–L249 are reserved and empty.

  • L240. keyboard_button_in_shell reads ${XDG_CONFIG_HOME:-$HOME/.config} instead of a hardcoded ~/.config, so a stopped shell still names a Keyboard button that lives in a custom config home.
  • L241. omarchy-gaming-session creates /etc/sudoers.d with install -dm750 (pkgrel 7). install -D had recorded the directory as 0755, and pacman warned that it differed from the filesystem's 0750. default/ does not ship sudoers.d. omarchy-settings still copies etc/ from omarchy-pkgs, which is outside this tree.
  • L242. A non-login omarchy update no longer dies with OMARCHY_PATH: unbound variable. omarchy-i18n, omarchy-update-dev and omarchy-update-keyring default it to /usr/share/omarchy, the same fallback as env-bootstrap and omarchy-migrate. omarchy-update exports that default for the rest of the update path.
  • L243. The press-test script traps HUP with restore_capture and exits 129. An SSH drop does not run EXIT, so inputplumber.service stayed stopped. IP_RESTORED still makes the following EXIT trap return without starting the service again.

Model: grok-4.7

Verification

  • bash test/shell.d/i18n-test.sh passed, including an unset OMARCHY_PATH.
  • bash test/shell.d/update-dev-test.sh passed, including an unset OMARCHY_PATH skipping the dev checkout.
  • bash test/shell.d/update-keyring-test.sh passed.
  • bash test/shell.d/ally-press-script-test.sh passed, including the HUP trap line and bash -n.
  • test/shell.d/hw-rog-ally-test.sh and test/shell.d/handheld-autologin-test.sh did not finish here: this host has no systemd-hwdb and no newuidmap. Those assertions run in the Tests workflow VM.

Screenshots

No visible change: command defaults, a package directory mode, and a research-script signal trap.

Open in Web Open in Cursor 

cursoragent and others added 5 commits November 17, 2026 04:24
The shell-down check looked only at ~/.config, so a custom config home hid the button.

Model: grok-4.7
Co-authored-by: Daniel Burbridge <DanielJBurbridge@users.noreply.github.com>
install -D was recording /etc/sudoers.d as 0755, which pacman warns differs from the filesystem's 0750.

Model: grok-4.7
Co-authored-by: Daniel Burbridge <DanielJBurbridge@users.noreply.github.com>
A non-login ssh command does not source env-bootstrap, so set -u aborted omarchy-i18n and the next update steps.

Model: grok-4.7
Co-authored-by: Daniel Burbridge <DanielJBurbridge@users.noreply.github.com>
SIGHUP does not run the EXIT trap, so a dropped session left inputplumber stopped. The HUP trap uses the same one-shot restore.

Model: grok-4.7
Co-authored-by: Daniel Burbridge <DanielJBurbridge@users.noreply.github.com>
1.0.0-7 already shipped in #84. The sudoers directory mode still needs a new release. L244–247 record the open review items and do not implement them.

Model: grok-4.7
Co-authored-by: Daniel Burbridge <DanielJBurbridge@users.noreply.github.com>
@cursor
cursor Bot force-pushed the fix/ally-lows-20261117 branch from 0146e17 to cacbd35 Compare November 17, 2026 04:24

@DanielJBurbridge DanielJBurbridge left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev-red: PASS at cacbd35 (Model: grok-4.7)

  • integ bbaac86 is an ancestor of the head; no '-' lines in alpha-followups.
  • All 5 commits carry Model: grok-4.7.
  • Actions test and i18n-check are green on cacbd35.
  • XDG_CONFIG_HOME read is still read-only (jq check only, no shell.json write).
  • install -dm750 etc/sudoers.d matches sudo's mode; pkgrel 8 resolves the #84 collision; only the PKGBUILD changed, so the unchanged sums are right.
  • OMARCHY_PATH fallback matches omarchy-migrate (/usr/share/omarchy).
  • HUP trap restores inputplumber and the EXIT trap is a no-op afterwards.

Low (no follow-up needed unless you want one): a dev checkout updated over a non-login ssh command now silently skips omarchy-update-dev instead of aborting, because unset OMARCHY_PATH falls back to the packaged tree. Better than the set -u abort, but worth a line in HANDOFF to export OMARCHY_PATH for dev checkouts.

@DanielJBurbridge
DanielJBurbridge merged commit d0d40b9 into feat/ally-parity-integration-20261111 Nov 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants