Skip to content

Disable handheld autologin when omarchy-dev is not a handheld build - #84

Merged
DanielJBurbridge merged 1 commit into
feat/ally-parity-integration-20261111from
fix/ally-autologin-guard-20261117
Nov 17, 2026
Merged

DanielJBurbridge merged 1 commit into
feat/ally-parity-integration-20261111from
fix/ally-autologin-guard-20261117

Conversation

@DanielJBurbridge

Copy link
Copy Markdown
Owner

What changes

Once upstream's base moves (for example to 4.0.1), omarchy update replaces handheld omarchy-dev and omarchy-settings-dev with packages that lack the session pieces. Relogin=true in /etc/sddm.conf.d/zz-omarchy-handheld.conf then loops SDDM. That already happened with the old dev.* scheme.

omarchy-gaming-session 1.0.0-7 ships a PostTransaction hook on install and upgrade of omarchy-dev and omarchy-settings-dev. The script reads pacman -Q omarchy-dev (the local database while pacman holds db.lck). A version that lacks .handheld and is not dev.* removes zz-omarchy-handheld.conf, the same drop-in omarchy-handheld-autologin apply writes. User=, the sudoers grant and TPM config stay. SDDM is not restarted. A .handheld or dev.* version leaves the drop-in. After those builds are installed again, sudo omarchy-handheld-autologin apply (or a reboot) turns autologin back on.

Claims follow-ups L250–L259. #82 is not merged, so L220 is not on this branch. L250 records that medium as fixed here. L251–L259 are claimed and empty.

Model: grok-4.7

Verification

bash test/shell.d/handheld-autologin-guard-test.sh passed. A fake pacman -Q omarchy-dev of 4.0.1.r1.g0000000 and 4.0.1.r1.g0000000-1 removes the drop-in and exits 0, including a second run. 4.0.0.202611170222.r8072.handheld.e742281c and dev.202611170222.e742281c (with and without -1) leave the drop-in, User=, the sudoers grant and the TPM hook file unchanged. With db.lck present the script does not call pacman and reads the local database the same way. The gaming-session source checksums match the PKGBUILD.

test/shell.d/handheld-autologin-test.sh did not run here: unshare failed with newuidmap: No such file or directory. That file's checksum loop was run on its own and the sums matched.

Screenshots

No visible change: the greeter is what SDDM shows at the next login after the drop-in is removed. This does not restart SDDM.

Open in Web Open in Cursor 

omarchy-gaming-session 1.0.0-7 removes zz-omarchy-handheld.conf when the installed omarchy-dev is not .handheld and not dev.*. User=, the sudoers grant and TPM config stay, and SDDM is not restarted. L250.

Model: grok-4.7
Co-authored-by: Daniel Burbridge <DanielJBurbridge@users.noreply.github.com>

@DanielJBurbridge DanielJBurbridge left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev-red review: PASS at b4f768c

(1) Boot path: it's gated, but only by accident. omarchy-handheld-autologin.service (copied to /etc, WantedBy=sddm.service) runs /usr/bin/omarchy-handheld-autologin apply before SDDM on every boot, and apply rewrites zz-omarchy-handheld.conf whenever handheld_variant is true. On a real upstream swap, that binary goes away: upstream bin/omarchy-handheld-autologin returns 404. ExecStart then fails, sddm still starts (it's a Wants, not a Requires), and the drop-in stays gone. So after a reboot it stays on the greeter, and autologin only comes back after a .handheld reinstall and apply, as intended. Low follow-up (L250 range): put the same version check in apply_dropin, or behind a shared helper, so the guard doesn't depend on upstream never shipping that command.

Checked:

  • The hook triggers on Install and Upgrade of omarchy-dev and omarchy-settings-dev at PostTransaction. The db.lck path reads local/omarchy-dev-*, and the guard fails open (leaves things alone) on an unreadable or ambiguous db. It refuses a symlinked drop-in, and trap 'exit 0' EXIT stops it failing the transaction.
  • handheld-autologin-guard-test passes locally: upstream 4.0.1.r1 and -1 disable autologin, .handheld and dev.* keep it, and both behave the same with the lock held. Actions test is green.
  • The PKGBUILD sums cover the 2 new files, and there's a Model trailer (grok-4.7). Integ e9fca47 is an ancestor of this head. Nothing is removed from the follow-ups.

Lows (L250 range):

  • omarchy-handheld-user.conf (User=) stays. By apply_dropin's own comment, SDDM then autologins into the last session. If that's omarchy-handheld.desktop, you get one failed attempt and then the greeter, since Relogin defaults to false. Worth checking once on the Ally.
  • The omarchy-dev-* glob also matches any future omarchy-dev-<something> package. That's "more than one", which leaves autologin on. Match omarchy-dev-[0-9d]* instead, or read each entry's %NAME% from desc.
  • Only omarchy-dev's version is checked. If upstream replaces only settings-dev, the guard won't fire.

(2) pkgrel: #83 also edits the gaming-session PKGBUILD. Whichever merges second has to rebase and bump past 7 (and update the sums).

Cleared to merge at this sha.

@DanielJBurbridge
DanielJBurbridge merged commit 10a24c6 into feat/ally-parity-integration-20261111 Nov 17, 2026
1 check passed
cursor Bot pushed a commit that referenced this pull request Nov 17, 2026
1.0.0-7 already shipped in #84. The sudoers directory mode still needs a new release. L244–247 record the open review items and do not implement them.

Model: grok-4.7
Co-authored-by: Daniel Burbridge <DanielJBurbridge@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants