Repository navigation
Disable handheld autologin when omarchy-dev is not a handheld build - #84
Conversation
omarchy-gaming-session 1.0.0-7 removes zz-omarchy-handheld.conf when the installed omarchy-dev is not .handheld and not dev.*. User=, the sudoers grant and TPM config stay, and SDDM is not restarted. L250. Model: grok-4.7 Co-authored-by: Daniel Burbridge <DanielJBurbridge@users.noreply.github.com>
DanielJBurbridge
left a comment
There was a problem hiding this comment.
dev-red review: PASS at b4f768c
(1) Boot path: it's gated, but only by accident. omarchy-handheld-autologin.service (copied to /etc, WantedBy=sddm.service) runs /usr/bin/omarchy-handheld-autologin apply before SDDM on every boot, and apply rewrites zz-omarchy-handheld.conf whenever handheld_variant is true. On a real upstream swap, that binary goes away: upstream bin/omarchy-handheld-autologin returns 404. ExecStart then fails, sddm still starts (it's a Wants, not a Requires), and the drop-in stays gone. So after a reboot it stays on the greeter, and autologin only comes back after a .handheld reinstall and apply, as intended. Low follow-up (L250 range): put the same version check in apply_dropin, or behind a shared helper, so the guard doesn't depend on upstream never shipping that command.
Checked:
- The hook triggers on Install and Upgrade of
omarchy-devandomarchy-settings-devat PostTransaction. The db.lck path readslocal/omarchy-dev-*, and the guard fails open (leaves things alone) on an unreadable or ambiguous db. It refuses a symlinked drop-in, andtrap 'exit 0' EXITstops it failing the transaction. handheld-autologin-guard-testpasses locally: upstream4.0.1.r1and-1disable autologin,.handheldanddev.*keep it, and both behave the same with the lock held. Actionstestis green.- The PKGBUILD sums cover the 2 new files, and there's a Model trailer (grok-4.7). Integ e9fca47 is an ancestor of this head. Nothing is removed from the follow-ups.
Lows (L250 range):
omarchy-handheld-user.conf(User=) stays. Byapply_dropin's own comment, SDDM then autologins into the last session. If that'somarchy-handheld.desktop, you get one failed attempt and then the greeter, since Relogin defaults to false. Worth checking once on the Ally.- The
omarchy-dev-*glob also matches any futureomarchy-dev-<something>package. That's "more than one", which leaves autologin on. Matchomarchy-dev-[0-9d]*instead, or read each entry's%NAME%fromdesc. - Only omarchy-dev's version is checked. If upstream replaces only settings-dev, the guard won't fire.
(2) pkgrel: #83 also edits the gaming-session PKGBUILD. Whichever merges second has to rebase and bump past 7 (and update the sums).
Cleared to merge at this sha.
10a24c6
into
feat/ally-parity-integration-20261111
1.0.0-7 already shipped in #84. The sudoers directory mode still needs a new release. L244–247 record the open review items and do not implement them. Model: grok-4.7 Co-authored-by: Daniel Burbridge <DanielJBurbridge@users.noreply.github.com>
What changes
Once upstream's base moves (for example to 4.0.1),
omarchy updatereplaces handheldomarchy-devandomarchy-settings-devwith packages that lack the session pieces.Relogin=truein/etc/sddm.conf.d/zz-omarchy-handheld.confthen loops SDDM. That already happened with the olddev.*scheme.omarchy-gaming-session1.0.0-7 ships a PostTransaction hook on install and upgrade ofomarchy-devandomarchy-settings-dev. The script readspacman -Q omarchy-dev(the local database while pacman holdsdb.lck). A version that lacks.handheldand is notdev.*removeszz-omarchy-handheld.conf, the same drop-inomarchy-handheld-autologin applywrites.User=, the sudoers grant and TPM config stay. SDDM is not restarted. A.handheldordev.*version leaves the drop-in. After those builds are installed again,sudo omarchy-handheld-autologin apply(or a reboot) turns autologin back on.Claims follow-ups L250–L259. #82 is not merged, so L220 is not on this branch. L250 records that medium as fixed here. L251–L259 are claimed and empty.
Model: grok-4.7
Verification
bash test/shell.d/handheld-autologin-guard-test.shpassed. A fakepacman -Q omarchy-devof4.0.1.r1.g0000000and4.0.1.r1.g0000000-1removes the drop-in and exits 0, including a second run.4.0.0.202611170222.r8072.handheld.e742281canddev.202611170222.e742281c(with and without-1) leave the drop-in,User=, the sudoers grant and the TPM hook file unchanged. Withdb.lckpresent the script does not call pacman and reads the local database the same way. The gaming-session source checksums match the PKGBUILD.test/shell.d/handheld-autologin-test.shdid not run here:unsharefailed withnewuidmap: No such file or directory. That file's checksum loop was run on its own and the sums matched.Screenshots
No visible change: the greeter is what SDDM shows at the next login after the drop-in is removed. This does not restart SDDM.