Skip to content

fix: migrate eyelash_sofle board to Zephyr 4.x board format #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: migrate eyelash_sofle board to Zephyr 4.x board format #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ff6d3f1
fix: migrate eyelash_sofle board to Zephyr 4.x new board format with …
Copilot Apr 3, 2026
02583c6
fix: remove conflicting eyelash_sofle external module from west.yml
Copilot Apr 3, 2026
1770be9
fix: resolve Kconfig warnings for Zephyr 4.x compatibility
Copilot Apr 3, 2026
9062f31
style: fix comment spacing in eyelash_sofle.conf
Copilot Apr 3, 2026
0509b57
fix: restore left encoder compatibility
Copilot Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions boards/arm/eyelash_sofle/Kconfig.board
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions boards/arm/eyelash_sofle/Kconfig.defconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,24 +19,9 @@ if BOARD_EYELASH_SOFLE_LEFT || BOARD_EYELASH_SOFLE_RIGHT
config BOARD
default "eyelash_sofle"

config BOARD_ENABLE_DCDC
bool "Enable DCDC mode"
select SOC_DCDC_NRF52X
default y
depends on (BOARD_EYELASH_SOFLE_LEFT || BOARD_EYELASH_SOFLE_RIGHT)

config BOARD_ENABLE_DCDC_HV
bool "Enable High Voltage DCDC converter"
default y
select SOC_DCDC_NRF52X_HV
depends on (BOARD_EYELASH_SOFLE_LEFT || BOARD_EYELASH_SOFLE_RIGHT)

config ZMK_SPLIT
default y

config BT_CTLR
default BT

if USB

config USB_NRFX
Expand Down
8 changes: 8 additions & 0 deletions boards/arm/eyelash_sofle/Kconfig.eyelash_sofle_left
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#
# Copyright (c) 2024 The ZMK Contributors
# SPDX-License-Identifier: MIT
#

config BOARD_EYELASH_SOFLE_LEFT

Copilot AI Apr 3, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BOARD_EYELASH_SOFLE_LEFT is being defined here but the entry is missing a Kconfig type (e.g., bool). The removed Kconfig.board defined this as a bool, and omitting the type can cause Kconfig parse errors or leave the symbol undefined. Add a bool (optionally with a prompt) before the select statements.

Suggested change
config BOARD_EYELASH_SOFLE_LEFT
config BOARD_EYELASH_SOFLE_LEFT
bool

Copilot uses AI. Check for mistakes.
select SOC_NRF52840_QIAA
select ZMK_BOARD_COMPAT
8 changes: 8 additions & 0 deletions boards/arm/eyelash_sofle/Kconfig.eyelash_sofle_right
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#
# Copyright (c) 2024 The ZMK Contributors
# SPDX-License-Identifier: MIT
#

config BOARD_EYELASH_SOFLE_RIGHT

Copilot AI Apr 3, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BOARD_EYELASH_SOFLE_RIGHT is being defined here but the entry is missing a Kconfig type (e.g., bool). In the previous Kconfig.board this symbol was a bool, and without a type Kconfig can fail to parse or leave the symbol undefined. Add a bool (optionally with a prompt) before the select statements.

Suggested change
config BOARD_EYELASH_SOFLE_RIGHT
config BOARD_EYELASH_SOFLE_RIGHT
bool

Copilot uses AI. Check for mistakes.
select SOC_NRF52840_QIAA
select ZMK_BOARD_COMPAT
9 changes: 9 additions & 0 deletions boards/arm/eyelash_sofle/board.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
boards:
- name: eyelash_sofle_left
vendor: eyelash
socs:
- name: nrf52840
- name: eyelash_sofle_right
vendor: eyelash
socs:
- name: nrf52840
4 changes: 4 additions & 0 deletions boards/arm/eyelash_sofle/eyelash_sofle.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,4 +233,8 @@ nice_view_spi: &spi0 {
pinctrl-1 = <&spi0_sleep>;
pinctrl-names = "default", "sleep";
cs-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>;
};

&reg0 {
status = "okay";
};
81 changes: 0 additions & 81 deletions boards/arm/eyelash_sofle/eyelash_sofle_left_defconfig
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion .../arm/eyelash_sofle/eyelash_sofle_left.dts → ...ash_sofle/eyelash_sofle_left_nrf52840.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,3 @@
&left_encoder {
status = "okay";
};

38 changes: 38 additions & 0 deletions boards/arm/eyelash_sofle/eyelash_sofle_left_nrf52840_defconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
#
# Copyright (c) 2022 Darryl deHaan
# SPDX-License-Identifier: MIT
#

CONFIG_ZMK_SLEEP=y

# Enable MPU
CONFIG_ARM_MPU=y

# enable pinctrl
CONFIG_PINCTRL=y

# enable GPIO
CONFIG_GPIO=y

# Enable SPI
CONFIG_SPI=y

# Enable writing to flash
CONFIG_USE_DT_CODE_PARTITION=y
CONFIG_BUILD_OUTPUT_UF2=y
CONFIG_MPU_ALLOW_FLASH_WRITE=y
CONFIG_NVS=y
CONFIG_SETTINGS_NVS=y
CONFIG_FLASH=y
CONFIG_FLASH_PAGE_LAYOUT=y
CONFIG_FLASH_MAP=y

# Enable 32kHz crystal
CONFIG_CLOCK_CONTROL_NRF_K32SRC_XTAL=y
CONFIG_CLOCK_CONTROL_NRF_K32SRC_30PPM=y

CONFIG_ZMK_USB=y
CONFIG_ZMK_BLE=y

# enable display drivers
CONFIG_ZMK_DISPLAY=y
1 change: 0 additions & 1 deletion ...arm/eyelash_sofle/eyelash_sofle_right.dts → ...sh_sofle/eyelash_sofle_right_nrf52840.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,3 @@
&default_transform {
col-offset = <7>;
};

4 changes: 0 additions & 4 deletions ...elash_sofle/eyelash_sofle_right_defconfig → ...le/eyelash_sofle_right_nrf52840_defconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@
# SPDX-License-Identifier: MIT
#

CONFIG_SOC_SERIES_NRF52X=y
CONFIG_SOC_NRF52840_QIAA=y
CONFIG_BOARD_EYELASH_SOFLE_RIGHT=y

# Enable 32kHz crystal
CONFIG_CLOCK_CONTROL_NRF_K32SRC_XTAL=y
CONFIG_CLOCK_CONTROL_NRF_K32SRC_30PPM=y
Expand Down
12 changes: 3 additions & 9 deletions config/eyelash_sofle.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ CONFIG_ZMK_SLEEP=y
CONFIG_CLOCK_CONTROL_NRF_K32SRC_XTAL=y
CONFIG_CLOCK_CONTROL_NRF_K32SRC_30PPM=y

CONFIG_WS2812_STRIP=y
CONFIG_ZMK_RGB_UNDERGLOW=y
CONFIG_ZMK_RGB_UNDERGLOW_EXT_POWER=y
CONFIG_ZMK_RGB_UNDERGLOW_ON_START=n
Expand All @@ -28,17 +27,12 @@ CONFIG_ZMK_RGB_UNDERGLOW_EFF_START=3

#CONFIG_ZMK_HID_CONSUMER_REPORT_USAGES_BASIC=y

#EC11 enable
CONFIG_EC11=y
CONFIG_EC11_TRIGGER_GLOBAL_THREAD=y

#EXT POWER
CONFIG_ZMK_EXT_POWER=y

# MOUSE
CONFIG_ZMK_POINTING=y

CONFIG_BT_CTLR_TX_PWR_PLUS_8=y
# EXT POWER
CONFIG_ZMK_EXT_POWER=y

CONFIG_ZMK_HID_REPORT_TYPE_NKRO=n

CONFIG_ZMK_BACKLIGHT=y
Expand Down
3 changes: 0 additions & 3 deletions config/west.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ manifest:
# - name: mario-peripheral-animation
# remote: gpeye
# revision: main
- name: eyelash_sofle
url: https://github.com/a741725193/zmk-sofle
revision: main
- name: zmk
remote: zmkfirmware
revision: main
Expand Down