Fix ObjC bridge generator for nested DataPoint types#2881
Draft
barboraplasovska wants to merge 1 commit into
Draft
Fix ObjC bridge generator for nested DataPoint types#2881barboraplasovska wants to merge 1 commit into
barboraplasovska wants to merge 1 commit into
Conversation
This was referenced May 5, 2026
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4f769b0 to
5f0cc9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What and why?
The ObjC interop code generator was walking all the way up to the top-level event class when resolving the root class for nested structs inside array items. This caused
DataPointwrapper classes to be typed asobjc_RUMTimeseriesCpuEventinstead ofobjc_RUMTimeseriesCpuEventTimeseriesData, breaking the generated bridge.Review checklist
make api-surfacewhen adding new APIs