Conversation
Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/5ff10973-f816-481f-8087-20104bd15b75 Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
DavidKRK
April 15, 2026 15:00
View session
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a language-switching gap in music.html where the YouTube section heading remained hardcoded in French by making the heading text JS-targetable and including it in the existing switchLanguage() translation updates.
Changes:
- Wrapped the YouTube
<h3>title text in a<span id="youtube-title-text">so it can be updated dynamically. - Added a new
youtube_titletranslation key for all supported languages in thelangContentmap. - Updated
switchLanguage()to also update the YouTube heading text (in addition to the existing button text).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
<h3>heading "Dernières vidéos YouTube" was hardcoded in French and ignored by theswitchLanguage()function, remaining untranslated when switching to any other language.Changes
music.html<span id="youtube-title-text">to make it JS-targetableyoutube_titlekey for all 6 languages (fr,en,es,eu,ar,uk) in thelangContentobjectswitchLanguage()to update the heading alongside the existing button text