[rtuck99]

No description provided.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.81%. Comparing base (6115b04) to head (722df18).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1245      +/-   ##
==========================================
+ Coverage   94.67%   94.81%   +0.13%     
==========================================
  Files          41       41              
  Lines        2611     2642      +31     
==========================================
+ Hits         2472     2505      +33     
+ Misses        139      137       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[DiamondJoseph]

Do you have a use case that requires this? To my mind this should be tracked in the dodal module, as the device_factory allows setting whether to connect sim or not, rather than having multiple potentially overlapping places to define this.

[tpoliaw]

There's currently no way (that I'm aware of?) of marking all device factories as mocks in one change so I can see the motivation for being able to mock an entire beamline in one flag.

This is all about to change though if the device manager change works out so it might be easier to change there? Other than the weirdness it introduces around having mock plans, I'm not against the idea of it being here as well though.

[tpoliaw]

Having a mock field on a plan module is odd. Can we split the Source type into a union where each sub type only has relevant fields?

[rtuck99]

Do you have a use case that requires this? To my mind this should be tracked in the dodal module, as the device_factory allows setting whether to connect sim or not, rather than having multiple potentially overlapping places to define this.

The use case is the same as the parent issue

• Add an option to connect to devices with mock=True #732

When hyperion moves to blueapi, we will be launching as standard blueapi plan + device modules, so without this option there will be no way to test it outside of connecting to real devices, if we want to be able to do integration testing.

I expect that this will come in handy when I start writing the hyperion-supervisor process, as then I will want to be able to verify that I can launch plans, monitor execution and do things like start and stop hyperion-blueapi plan execution when the baton is taken away, etc. etc.

[rtuck99]

There's currently no way (that I'm aware of?) of marking all device factories as mocks in one change so I can see the motivation for being able to mock an entire beamline in one flag.

This is all about to change though if the device manager change works out so it might be easier to change there? Other than the weirdness it introduces around having mock plans, I'm not against the idea of it being here as well though.

I agree the configuration is slightly weird, I can investigate changing the Source type. If the device manager will let us do this more neatly that would be ok, but it does need to be something that can be set up via configuration so that I can do things like run hyperion-blueapi in a test container. So I think it would still require a change in blueapi since that is what drives loading of the beamline module.

I'm not sure what the plan is currently for getting the device manager into dodal - on its own the PR DiamondLightSource/dodal#1549 doesn't provide anything without accompanying changes in dodal device modules and blueapi, and it seems the related discussion DiamondLightSource/dodal#1574 is stalled at the moment.

[tpoliaw]

m not sure what the plan is currently for getting the device manager into dodal - on its own the PR DiamondLightSource/dodal#1549 doesn't provide anything without accompanying changes in dodal device modules and blueapi, and it seems the related discussion DiamondLightSource/dodal#1574 is stalled at the moment.

The change in dodal is mostly complete. For now, both approaches are supported and beamlines can try using the new version when they get a chance. I have made an example change for i04 in #1684.

For the blueapi side, the aim is to support the old loading for a short transition period then move everyone to the new system. As part of that I'll make sure mock is support is included.

Do you mind if I merge this PR into that change?

[rtuck99]

Closing this PR in favour of

• feat: Add support for device manager beamline modules #1267
  and associated device manager PRs