Repository navigation
Ability to launch blueapi and run Hyperion plans - #1389
Merged
Merged
Conversation
This was referenced Oct 21, 2025
Contributor
|
Ready to review, assuming linked PRs get merged |
DominicOram
self-requested a review
November 24, 2025 10:13
rtuck99
force-pushed
the
hyperion_on_blueapi
branch
from
December 4, 2025 16:47
552fdcf to
1c13914
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1389 +/- ##
==========================================
+ Coverage 92.30% 92.32% +0.01%
==========================================
Files 142 143 +1
Lines 8107 8126 +19
==========================================
+ Hits 7483 7502 +19
Misses 624 624
🚀 New features to boost your workflow:
|
4 tasks
rtuck99
force-pushed
the
hyperion_on_blueapi
branch
from
December 8, 2025 14:27
a02ffb7 to
0b3292e
Compare
rtuck99
marked this pull request as ready for review
December 8, 2025 14:35
This was referenced Dec 18, 2025
rtuck99
force-pushed
the
hyperion_on_blueapi
branch
from
January 5, 2026 16:12
211fb63 to
575614e
Compare
jacob-williamson
self-requested a review
January 7, 2026 11:37
jacob-williamson
approved these changes
Jan 7, 2026
jacob-williamson
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, the only thing I didn't try was actually running the plans
| "params": { | ||
| "visit": "cm12345-1" | ||
| }, | ||
| "instrument_session": "cm12345-1" |
Contributor
There was a problem hiding this comment.
Is visit needed as well as instrument session?
Contributor
Author
There was a problem hiding this comment.
instrument_session is needed by blueapi. It is now exposed to callbacks in the run engine metadata. I think in future we will be able to get rid of the visit parameter, but we will need to update the callbacks, once everyone is on blueapi I think we can do this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Requires
feat: Add option to connect as mock devices blueapi#1245feat: Add support for device manager beamline modules blueapi#1267(remember to update
pyproject.tomlwith the dodal commit tag if you need it for tests to pass!)Note:
This PR requires updating when
is merged
Instructions to reviewer on how to test:
It should now be possible to
run_hyperion.shscript with the--blueapiflag, and connected to mock devices with the--devflagload_centre_collect,robot_unloadandmove_to_udc_default_stateplans with blueapi/plansendpointChecks for reviewer