Skip to content

Fixes to support hyperion-blueapi - #1760

Merged
rtuck99 merged 3 commits into
mainfrom
mx-bluesky_1364_fix_generic_params_in_robot_protocol
Jan 8, 2026
Merged

rtuck99 merged 3 commits into
mainfrom
mx-bluesky_1364_fix_generic_params_in_robot_protocol

Conversation

@rtuck99

@rtuck99 rtuck99 commented Dec 5, 2025 •

Copy link
Copy Markdown
Contributor

Change BartRobot to use a sentinel instead of None for the empty location

Fixes DiamondLightSource/mx-bluesky#1364

See also mx-bluesky changes:

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov

codecov Bot commented Dec 5, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.12%. Comparing base (3fe8680) to head (cbe5774).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1760   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files         286      286           
  Lines       10786    10787    +1     
=======================================
+ Hits        10692    10693    +1     
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99
rtuck99 marked this pull request as ready for review December 8, 2025 14:23
@rtuck99
rtuck99 requested a review from a team as a code owner December 8, 2025 14:23
@rtuck99
rtuck99 force-pushed the mx-bluesky_1364_fix_generic_params_in_robot_protocol branch from 2adb761 to ba979d5 Compare December 8, 2025 14:24
@rtuck99
rtuck99 force-pushed the mx-bluesky_1364_fix_generic_params_in_robot_protocol branch from ba979d5 to a946a46 Compare January 5, 2026 16:01
@jacob-williamson
jacob-williamson self-requested a review January 7, 2026 11:37

@jacob-williamson jacob-williamson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rtuck99
rtuck99 enabled auto-merge (squash) January 8, 2026 11:25
@rtuck99
rtuck99 merged commit a03a288 into main Jan 8, 2026
8 checks passed
@rtuck99
rtuck99 deleted the mx-bluesky_1364_fix_generic_params_in_robot_protocol branch January 8, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hyperion experiment plans running in blueapi

2 participants