Skip to content

Fix tests for latest bluesky - #206

Merged
DominicOram merged 8 commits into
mainfrom
fix_tests_for_latest_bluesky
Nov 3, 2026
Merged

DominicOram merged 8 commits into
mainfrom
fix_tests_for_latest_bluesky

Conversation

@jacob-williamson

@jacob-williamson jacob-williamson commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #205
Requires DiamondLightSource/dodal#2256 for lint, our typing is a lot stronger since the copier update
Also adds a stage to pre-commit so that a local editable dodal is installed

@jacob-williamson

Copy link
Copy Markdown
Contributor Author

Slightly weird behaviour with the run engine simulator, it seems that the first device being read is msg.obj and subsequent are in msg.args

@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (31b978e) to head (6406f1f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files          16       16           
  Lines         481      481           
=======================================
  Hits          442      442           
  Misses         39       39           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DominicOram

Copy link
Copy Markdown
Contributor

Slightly weird behaviour with the run engine simulator, it seems that the first device being read is msg.obj and subsequent are in msg.args

Yh, I made bluesky/bluesky#2102

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! I'm not sure I like the new pre-commit hook. Seems very opinionated and unrelated to the issue. If you're passionate about doing it can you spin it into a new issue/PR

@jacob-williamson

Copy link
Copy Markdown
Contributor Author

Yeah sorry it's completely unrelated, will remove

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@DominicOram
DominicOram merged commit edc9c9d into main Nov 3, 2026
9 checks passed
@DominicOram
DominicOram deleted the fix_tests_for_latest_bluesky branch November 3, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Latest bluesky version breaks tests

2 participants