Skip to content

Improve zebra typing - #2256

Merged
DominicOram merged 1 commit into
mainfrom
improve_zebra_typing
Nov 2, 2026
Merged

DominicOram merged 1 commit into
mainfrom
improve_zebra_typing

Conversation

@jacob-williamson

@jacob-williamson jacob-williamson commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

This was causing lint to fail downstream in crystallography-bluesky DiamondLightSource/crystallography-bluesky#206

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@jacob-williamson
jacob-williamson requested a review from a team as a code owner November 2, 2026 17:47
@jacob-williamson jacob-williamson changed the title Improve typing Improve zebra typing Nov 2, 2026
@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.30%. Comparing base (546b1fe) to head (6715d55).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2256   +/-   ##
=======================================
  Coverage   99.30%   99.30%           
=======================================
  Files         376      376           
  Lines       14798    14798           
=======================================
  Hits        14695    14695           
  Misses        103      103           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@DominicOram
DominicOram merged commit 01e660f into main Nov 2, 2026
10 of 11 checks passed
@DominicOram
DominicOram deleted the improve_zebra_typing branch November 2, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants