Skip to content

Fix tiled data shape by correcting trigger info - #213

Open
jacob-williamson wants to merge 2 commits into
mainfrom
fix_tiled_data_shape
Open

jacob-williamson wants to merge 2 commits into
mainfrom
fix_tiled_data_shape

Conversation

@jacob-williamson

Copy link
Copy Markdown
Contributor

Requires bluesky/ophyd-async#1495
We have only been able to read the first frame of a collection out of tiled, as it had the wrong data shape. This is because we were giving collections_per_event=1, number_of_events=1 in TriggerInfo, and manually setting the ntrigger PV, so tiled thought we were only taking one frame. The above ophyd-async fix means we can put the correct values into TriggerInfo.

@codecov

codecov Bot commented Nov 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (e710f75) to head (524a68e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
- Coverage   91.90%   91.89%   -0.02%     
==========================================
  Files          16       16              
  Lines         482      481       -1     
==========================================
- Hits          443      442       -1     
  Misses         39       39              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant