Repository navigation
Set ntrigger rather than nimages when preparing eiger - #1495
Open
jacob-williamson wants to merge 1 commit into
Open
jacob-williamson wants to merge 1 commit into
jacob-williamson wants to merge 1 commit into
Conversation
Contributor
Author
|
Maybe #1496 could work? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for #1288 and needed for DiamondLightSource/crystallography-bluesky#213.
On i15-1 we trigger the eiger
n_framestimes through the zebra, getting one frame per trigger. I'm aware other beamlines trigger the eiger differently, how should this be resolved? The issue boils down to the fact thatprepare_edgeonly takes on number. Really we want it to taken_triggersandn_images(frames per trigger) so it can set both PVs accordingly