Repository navigation
Fix tests for new device manager - #1459
Merged
Merged
Conversation
rtuck99
force-pushed
the
convert_to_device_manager
branch
from
November 21, 2025 13:01
a4b6374 to
c2a7515
Compare
rtuck99
approved these changes
Nov 21, 2025
rtuck99
left a comment
rtuck99
left a comment
Contributor
There was a problem hiding this comment.
Approved pending merge of dependent changes in
DiamondLightSource/dodal#1684
DiamondLightSource/dodal#1549
and
DiamondLightSource/blueapi#1267
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1459 +/- ##
==========================================
- Coverage 92.26% 92.24% -0.03%
==========================================
Files 142 142
Lines 8033 8033
==========================================
- Hits 7412 7410 -2
- Misses 621 623 +2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to work for new device manager. Loading the devices into the BlueAPI context is still broken, we will need DiamondLightSource/blueapi#1267 for this.
Link to dodal PR (if required): DiamondLightSource/dodal#1684
Instructions to reviewer on how to test:
Checks for reviewer