Skip to content

🐛 history: preserve comparison currencies and batch fiat requests - #86

Merged
DimaMishchenko merged 1 commit into
mainfrom
bug/details-reference-currency
Oct 15, 2026
Merged

DimaMishchenko merged 1 commit into
mainfrom
bug/details-reference-currency

Conversation

@DimaMishchenko

@DimaMishchenko DimaMishchenko commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

🔗 Related issue

Follow-up to #83.

📝 Summary

Details keeps the selected comparison currency, including BTC priced in EUR and crypto-to-crypto pairs. Tiny positive rates and chart movements remain visible.

Covered fiat pairs use at most two ECB/CBU range requests instead of 366 dated downloads. Unavailable pairs retain Fawaz fallback. Matching-date EUR cross-rates cover AED; fresh caches and the current bundled All archive need zero history requests. Saved charts remain available when refresh fails.

🧪 Validation

  • CI passed, including iOS tests, Watch, extracted App Intents and harness builds.
  • App/widgets/embedded Watch build passed; 179 native tests (1,018 parameterized executions), zero failures/skips.
  • 10 installed-phone journeys and the dependent History widget journey passed, including live BTC USD/EUR and fiat USD/EUR/AED history, range switching and exact cache reuse after relaunch.
  • EUR → AED in this run: cold 1Y 1.91s, bundled All 0.93s, cached 1Y 1.03s.
  • Formatting, localization, types and structure passed; independent review found no P1/P2 issues.
  • Crypto daily 1Y still uses Fawaz. Watch charts were built/model-tested without a Watch UI run.
Before/after and real-data screenshots

Before: EUR converter incorrectly opens BTC in USD

After: BTC retains the selected EUR comparison

Tiny VND/BTC values and chart movement remain visible

Real Coin Metrics BTC/EUR intraday data

Real AED/EUR daily year from Frankfurter

Bundled AED/EUR monthly All history

Installed History widget retains its configured pair, value and chart

* keep selected Details pairs and display tiny reference values accurately
* load daily fiat charts through bounded ECB and CBU range requests
* cover pair combinations, provider failures, live data and cache reuse
@DimaMishchenko
DimaMishchenko marked this pull request as ready for review October 15, 2026 16:25
@DimaMishchenko
DimaMishchenko merged commit 5775516 into main Oct 15, 2026
2 checks passed
@DimaMishchenko
DimaMishchenko deleted the bug/details-reference-currency branch October 15, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant