Repository navigation
feat(avatar): engine_render_gated manifest + DemoWindowController shell guard (#225) - #6
Merged
Merged
Conversation
…r shell guard (#225) Workspace-tile support for the desktop-avatar sample, pairing with the runtime xrGetWorkspaceTileSizeDXR + provider consumption + shell per-app show mode (displayxr-shell-pvt#80): - installer/common/SampleInstaller.nsh: emit "engine_render_gated": true in the registered-mode manifest. Unity apps gate render on the main window being SHOWN, so the shell must launch them SW_SHOWMINNOACTIVE (not SW_HIDE); the flag opts every Unity sample into that per-app show mode. - DemoWindowController: no-op in shell/tile mode (displayxr_is_shell_mode()). The shell/runtime own the tile window there; persisting/restoring our saved size would fight the runtime's tile-resize AND corrupt the standalone size (it would save the tile size to PlayerPrefs). Standalone behavior unchanged. The provider reports the tile canvas via the size APIs, so the avatar authors its zone/Local2D for the tile with no default-resolution change needed. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Umm4stoD3G9SuNeocafhPn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workspace-tile support for desktop-avatar, part of the joint tile-sizing release.
Changes
installer/common/SampleInstaller.nsh— emit"engine_render_gated": truein the registered-mode manifest. Unity apps gate their render on the main window being shown, so the shell must launch themSW_SHOWMINNOACTIVE(notSW_HIDE, which is black); this flag opts every Unity sample into the shell's per-app show mode (displayxr-shell-pvt#80).DemoWindowController.cs— no-op in shell/tile mode (displayxr_is_shell_mode()). The shell/runtime own the tile window; persisting/restoring our saved size there fights the runtime's tile-resize and would corrupt the standalone size (it'd save the tile size to PlayerPrefs). Standalone behavior unchanged.No Unity default-resolution change: the provider now reports the tile canvas via the size APIs (plugin PR displayxr-unity#226), so the avatar authors its zone/Local2D for the tile directly.
Ships with
xrGetWorkspaceTileSizeDXR(spec v2) + #225 zones fix (displayxr-runtime#779)HW-validated (Leia SR): desktop-avatar renders tile-sized stereo + tracks resize. Keyboard/mouse to tiles is a tracked follow-up (not a blocker).
🤖 Generated with Claude Code
https://claude.ai/code/session_01Umm4stoD3G9SuNeocafhPn