Skip to content

feat(avatar): engine_render_gated manifest + DemoWindowController shell guard (#225) #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfattal merged 1 commit into from
Jul 23, 2026
Merged

feat(avatar): engine_render_gated manifest + DemoWindowController shell guard (#225) #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions installer/common/SampleInstaller.nsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,11 @@ Section "${SAMPLE_DISPLAY_NAME}" SecApp
FileWrite $0 ' "icon": "icon_${SAMPLE_SLUG}.png",$\r$\n'
FileWrite $0 ' "icon_3d": "icon_sbs_${SAMPLE_SLUG}.png",$\r$\n'
FileWrite $0 ' "icon_3d_layout": "sbs-lr",$\r$\n'
; Unity/engine apps gate their render on the main window being SHOWN, so the
; shell must launch them SW_SHOWMINNOACTIVE (not SW_HIDE) and they read
; xrGetWorkspaceTileSizeDXR for tile size. Opt-in flag consumed by the shell's
; per-app show mode (displayxr-shell-pvt#80). All Unity samples are engine-gated.
FileWrite $0 ' "engine_render_gated": true,$\r$\n'
${WordReplace} "$INSTDIR" "\" "/" "+" $1
FileWrite $0 ' "exe_path": "$1/${APP_EXE}"$\r$\n'
FileWrite $0 '}$\r$\n'
Expand Down
8 changes: 8 additions & 0 deletions samples/desktop-avatar/Assets/DemoWindowController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,14 @@ void Update()
#if UNITY_STANDALONE_WIN
if (Application.isEditor) return;

// Workspace-tile mode (#225): the shell/runtime owns the window — it
// syncs the hidden window to the tile's 3D-window pixel rect so Kooima
// (from the tile pose) matches the render aspect (this is what every
// other tile app gets for free). Restoring/persisting our own portrait
// size here overrides that cell-resize and mismatches Kooima → the whole
// scene stretches. So this window-chrome policy is inert as a tile.
if (DisplayXRNative.displayxr_is_shell_mode() != 0) return;

// Remember / restore window size AND position across launches (the split
// persists separately in TigerSpeechBubble). On the first valid frame,
// restore the last-saved size + position; thereafter, track changes in
Expand Down