Repository navigation
fix(cursor): halve the depth-cursor margin to 0.015 (ADR-046 A.2) - #169
Merged
Merged
Conversation
Panel feedback: with 0.03 eye baselines (~2 mm crossed on-screen disparity) the depth cursor floats visibly in front of the content. Runtime ADR-046 Amendment 2 A.2 is halved to 0.015 (~1 mm at a 63-65 mm IPD); the runtime makes the same change, so web and native cursors agree. CURSOR_DEFAULT_TUNING.margin is the single source: DepthCursor, cursor: 'depth' on ./model and ./splat (both engines) and the stereo-tile pair cursor all take it from the core; no local copy remains. `margin` still overrides it. Types, the authoring doc and CHANGELOG (Unreleased, deliberate default change) are updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
David's panel feedback: with the 0.03 default the depth cursor floats too far in front of the content. Runtime ADR-046 Amendment 2 A.2 is halved to 0.015 eye baselines, about 1 mm of crossed on-screen disparity at a 63–65 mm IPD instead of about 2 mm. The runtime makes the same change in DisplayXR/displayxr-runtime#1965, so web and native cursors still agree.
js/inline3d-cursor-depth.js:CURSOR_DEFAULT_TUNING.margin0.03 → 0.015. This is the single source.DepthCursor(./three),cursor: 'depth'on./model/./splat(three and PlayCanvas), and the stereo-tile pair cursorjs/camera/pair-cursor.jsall take the margin from the core. A grep found no local copy left: everymarginoption ismargin > 0 ? {...CURSOR_DEFAULT_TUNING, margin} : CURSOR_DEFAULT_TUNING. The only other0.03hits were in comments and JSDoc, and those are updated too.cursor-depth.d.ts,model.d.ts,splat.d.ts, theDepthCursorJSDoc, and the cursor section ofdocs/authoring-inline-3d.md.CHANGELOG.md: a new## Unreleasedentry marks this as a deliberate default change in both the core and preview tiers. To get the 1.41.0 look back, passmargin: 0.03.CURSOR_DEFAULT_TUNING.Evidence
npm test: tsc passes, and 918 of 918 tests pass.cursor-depth.test.mjs, and the target, units and PairCursor tests inpair-cursor.test.mjs.cursorTarget(T, true, -0.2) === -0.215.npm run -s api:check: the snapshots match.npm run -s check:snippets: 22 files typecheck.npm run -s test:e2e:cursoron the real viewers in headless Chrome: PASS.playcanvas/model,three/model,playcanvas/model/screenandthree/model/worldall give cursor −0.1688 with the cube front at −0.1538, which is front − 0.015 exactly.null(nothing is drawn).Not tested
sdk-v*.🤖 Generated with Claude Code