Skip to content

Move autosave status to editor header #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssavutu merged 1 commit into from
Aug 2, 2026
Merged

Move autosave status to editor header #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 20 additions & 16 deletions frontend/src/pages/editArticleView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,13 +710,16 @@
}, AUTOSAVE_DELAY_MS)

return () => window.clearTimeout(timer)
}, [articleSnapshot, isAutoSaving, isLoading, isNew, isSaving, lockedBy, publishTiming, publishedAt, selectedAuthorId, selectedCategorySlugs])

Check warning on line 713 in frontend/src/pages/editArticleView.tsx

View workflow job for this annotation

GitHub Actions / frontend 

React Hook useEffect has a missing dependency: 'saveArticle'. Either include it or remove the dependency array

const inputClass ="w-full px-3 py-2 rounded-lg border border-border bg-background text-sm text-foreground placeholder:text-muted-foreground focus:outline-none focus:ring-2 focus:ring-primary/40 focus:border-primary transition"
const selectClass = "w-full px-3 py-2 rounded-lg border border-border bg-background text-sm text-foreground focus:outline-none focus:ring-2 focus:ring-primary/40 focus:border-primary transition"
const labelClass = "flex flex-col gap-1.5"
const labelTextClass = "text-xs font-semibold text-muted-foreground uppercase tracking-wide"
const publishDateInFuture = publishTiming === "schedule" && isFutureDate(publishedAt)
const autoSaveStatusText = !isNew && (isAutoSaving || autoSaveMessage)
? (isAutoSaving ? "Autosaving..." : autoSaveMessage)
: null
const publishDateHint = (() => {
if (publishTiming !== "schedule") return "Publishes immediately."
if (!publishedAt) return "Choose when this should go live."
Expand Down Expand Up @@ -824,16 +827,23 @@
return (
<div className="flex flex-col gap-6 p-6">
{/* Header */}
<div className="flex items-center gap-4">
<button
className="inline-flex items-center gap-1.5 px-3 py-2 rounded-lg text-sm text-muted-foreground hover:text-foreground hover:bg-muted transition-colors"
onClick={() => navigate(-1)}
type="button"
>
<ArrowLeft className="w-4 h-4" aria-hidden="true" />
Back
</button>
<h1 className="text-2xl font-bold text-foreground">{isNew ? "New Article" : "Edit Article"}</h1>
<div className="flex flex-col gap-3 sm:flex-row sm:items-center">
<div className="flex items-center gap-4">
<button
className="inline-flex items-center gap-1.5 px-3 py-2 rounded-lg text-sm text-muted-foreground hover:text-foreground hover:bg-muted transition-colors"
onClick={() => navigate(-1)}
type="button"
>
<ArrowLeft className="w-4 h-4" aria-hidden="true" />
Back
</button>
<h1 className="text-2xl font-bold text-foreground">{isNew ? "New Article" : "Edit Article"}</h1>
</div>
{autoSaveStatusText ? (
<p className="rounded-lg bg-muted/70 px-3 py-2 text-xs text-muted-foreground sm:ml-auto">
{autoSaveStatusText}
</p>
) : null}
</div>

{isLoading ? (
Expand Down Expand Up @@ -1184,12 +1194,6 @@
{successMessage}
</p>
)}
{!isNew && (isAutoSaving || autoSaveMessage) ? (
<p className="text-xs text-muted-foreground bg-muted/60 rounded-lg px-3 py-2">
{isAutoSaving ? "Autosaving..." : autoSaveMessage}
</p>
) : null}

<div className="flex flex-col gap-2 pt-1">
<button
className="inline-flex items-center justify-center gap-2 px-4 py-2 rounded-lg bg-primary text-primary-foreground text-sm font-medium hover:bg-primary/90 transition-colors disabled:opacity-50 disabled:cursor-not-allowed"
Expand Down
Loading