Add per-NPC event history and injection - #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
📜 Historylast in the native Stobe editor tab orderinputtextevents for NPCs outside the current sceneProfile VersionslabelWhy
NPCs need to retain cross-scene handoffs and other roleplay context even when they are not currently together.
Stobe persists event recipients as JSON strings such as
Herika|hand_801757824. The initial port only split pipe-delimited routing, so every native Stobe event missed the exact-NPC predicate and History appeared empty. This branch now parses Stobe's native JSON roster, removes runtime handle/status suffixes for exact matching and display, and retains legacy pipe-format compatibility.Maintainer Discussion
RANGROOortyler.maisterin Discord.Related PRs
HerikaServer reference PR: abeiro/HerikaServer#689
Notes
inputtextevent/context path.|hand_...and audience-state suffixes.Validation
php -l lib/eventlog_helper.phpphp -l ui/api/stobe_npc_history.phpphp -l ui/adventurelog.phpphp -l ui/stobenpcs.phpnode --check ui/js/npc_event_history.jsgit diff --checkSTOBE_DB_NAME=stobe_test php tests/ingress_people_regression.phpSTOBE_DB_NAME=stobe_test php tests/npc_history_snapshot_regression.phpstobe_testAPI round trip covered inject/read/filter/delete; this follow-up did not insert or delete a new event, so the JSON write-format change is source-, lint-, and CI-validatedProfile VersionsPHP Regression TestsworkflowLocal Deployment
b5f62dcto/var/www/html/StobeServerinDwemerAI4Skyrim312346